JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts #15644

mcpowers · 2023-09-08T19:41:47Z

https://bugs.openjdk.org/browse/JDK-8296631

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts (Bug - P3)

Reviewers

Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15644/head:pull/15644
$ git checkout pull/15644

Update a local copy of the PR:
$ git checkout pull/15644
$ git pull https://git.openjdk.org/jdk.git pull/15644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15644

View PR using the GUI difftool:
$ git pr show -t 15644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15644.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-09-08T19:42:36Z

👋 Welcome back mpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-09-08T19:44:58Z

@mcpowers The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-09-08T19:48:56Z

Webrevs

valeriepeng · 2023-09-13T00:12:55Z

I will take a look. Thanks!

valeriepeng · 2023-09-14T23:18:39Z

test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java

+        double version = getNSSVersion();
+        if (version == 0.0 || version >= 3.55) {
+            useSqlite(true);
+        }


Instead of updating various tests with this block, how about doing this inside SecmodTest.initSecmod()?

Such a change would apply NSS version number checks to TestNssDbSqlite which currently doesn't have them. But wait! If TestNssDbSqlite has been running for years on all NSS versions, then it should be safe to make sqlite the default for all tests.

Yes, for new NSS releases, it should be safe to set sqlite to true by default. The tests which relies on sqlite like TestNssDbSqlite can always call useSqlite(true) regardless of default.

@valeriepeng Thanks for the review! I'll set sqlite to true by default and retest.

valeriepeng · 2023-09-20T22:16:07Z

Just curious, there are already test/jdk/sun/security/pkcs11/Secmod/cert9.db and test/jdk/sun/security/pkcs11/Secmod/key4.db, what are the reasons for updating them? Since it's binary file, I can't tell what changes they are for...
In addition, do we need to check all PKCS11 tests which have key3.db and cert8.db and add corresponding key4.db/cert9.db?

mcpowers · 2023-09-21T00:31:37Z

Without updating Secmod/cert9.db and Secmod/key4.db, both Secmod/JksSetPrivateKey and Secmod/GetPrivateKey will fail. The old values must have been incorrect. This was not noticed because cert8.db and key3.db were used if there were a libnssdbm3 on the machine. In OL9, there is no libnssdbm3, so the failures appeared.

Regarding your second question, every cert8/key3 pair has a cert9/key4 pair except for pkcs11/tls tests which only have cert8/key3.

valeriepeng · 2023-09-22T23:59:43Z

Without updating Secmod/cert9.db and Secmod/key4.db, both Secmod/JksSetPrivateKey and Secmod/GetPrivateKey will fail. The old values must have been incorrect. This was not noticed because cert8.db and key3.db were used if there were a libnssdbm3 on the machine. In OL9, there is no libnssdbm3, so the failures appeared.

Regarding your second question, every cert8/key3 pair has a cert9/key4 pair except for pkcs11/tls tests which only have cert8/key3.

Thanks for the explanation~
Then what happens to the pkcs11/tls/tls12 test which does not have cert9.db/key4.db? Will they continue to work against newer NSS releases with default sqlite=true?

mcpowers · 2023-09-28T04:23:34Z

Good point. No it does not work. The test failed to initialize the NSS module, printed "skipping", and returned pass. I converted the cert8/key3 pair to cert9/key4 and created a pkcs11.txt file. Now it works.

valeriepeng · 2023-09-28T20:22:40Z

Thanks, changes look good to me.

openjdk · 2023-09-28T20:24:36Z

@mcpowers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296631: NSS tests failing on OL9 linux-aarch64 hosts

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 158 new commits pushed to the master branch:

878d27d: 8317273: compiler/codecache/OverflowCodeCacheTest.java fails transiently on Graal
2637e8d: 8317314: Remove unimplemented ObjArrayKlass::oop_oop_iterate_elements_bounded
8093563: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously
516cfb1: 8316907: Fix nonnull-compare warnings
5984792: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
eeb63cd: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
6948942: 8317327: Remove JT_JAVA dead code in jib-profiles.js
795e5dc: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration
207819a: 8315604: IGV: dump and visualize node bottom and phase types
8fcf70e: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes
... and 148 more: https://git.openjdk.org/jdk/compare/a021dbcb9e58ab60abfc8c46ff25f3aa8ce3cc9f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@valeriepeng) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mcpowers · 2023-10-02T15:03:37Z

@valeriepeng Thanks for the review!

mcpowers · 2023-10-02T15:03:54Z

/integrate

openjdk · 2023-10-02T15:04:38Z

@mcpowers
Your change (at version 2c6fb4a) is now ready to be sponsored by a Committer.

valeriepeng · 2023-10-02T22:41:41Z

/sponsor

openjdk · 2023-10-02T22:43:53Z

Going to push as commit 6e1aacd.
Since your change was applied there have been 165 commits pushed to the master branch:

d2e2c4c: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry
e25121d: 8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries
5c8366e: 8268622: Performance issues in javac Name class
ad81abd: 8317034: Remove redundant type cast in the java.util.stream package
d7d1d42: 8316771: Krb5.java has not defined messages for all error codes
f985006: 8309356: Read files in includedir in alphanumeric order
a564d43: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
878d27d: 8317273: compiler/codecache/OverflowCodeCacheTest.java fails transiently on Graal
2637e8d: 8317314: Remove unimplemented ObjArrayKlass::oop_oop_iterate_elements_bounded
8093563: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously
... and 155 more: https://git.openjdk.org/jdk/compare/a021dbcb9e58ab60abfc8c46ff25f3aa8ce3cc9f...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-10-02T22:44:07Z

@valeriepeng @mcpowers Pushed as commit 6e1aacd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mcpowers added 3 commits September 7, 2023 16:44

first iteration

89439ac

Merge

2427d24

second iteration

3885f00

openjdk bot added the rfr Pull request is ready for review label Sep 8, 2023

openjdk bot added the security security-dev@openjdk.org label Sep 8, 2023

valeriepeng reviewed Sep 14, 2023

View reviewed changes

mcpowers added 2 commits September 20, 2023 09:24

comment from Valerie

8822b76

Merge

1439d19

mpdonova mentioned this pull request Sep 26, 2023

8314283: Support for NSS tests on aarch64 platforms #15429

Closed

3 tasks

more sqlite conversion needed

2c6fb4a

valeriepeng approved these changes Sep 28, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 2, 2023

openjdk bot added the integrated Pull request has been integrated label Oct 2, 2023

openjdk bot closed this Oct 2, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 2, 2023

mcpowers deleted the JDK-8296631 branch October 3, 2023 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts #15644

JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts #15644

mcpowers commented Sep 8, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 8, 2023

openjdk bot commented Sep 8, 2023

mlbridge bot commented Sep 8, 2023 •

edited

Loading

valeriepeng commented Sep 13, 2023

valeriepeng Sep 14, 2023

mcpowers Sep 18, 2023

valeriepeng Sep 19, 2023

mcpowers Sep 20, 2023

valeriepeng commented Sep 20, 2023

mcpowers commented Sep 21, 2023

valeriepeng commented Sep 22, 2023

mcpowers commented Sep 28, 2023

valeriepeng commented Sep 28, 2023

openjdk bot commented Sep 28, 2023 •

edited

Loading

mcpowers commented Oct 2, 2023

mcpowers commented Oct 2, 2023

openjdk bot commented Oct 2, 2023

valeriepeng commented Oct 2, 2023

openjdk bot commented Oct 2, 2023

openjdk bot commented Oct 2, 2023

JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts #15644

JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts #15644

Conversation

mcpowers commented Sep 8, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Sep 8, 2023

openjdk bot commented Sep 8, 2023

mlbridge bot commented Sep 8, 2023 • edited Loading

Webrevs

valeriepeng commented Sep 13, 2023

valeriepeng Sep 14, 2023

Choose a reason for hiding this comment

mcpowers Sep 18, 2023

Choose a reason for hiding this comment

valeriepeng Sep 19, 2023

Choose a reason for hiding this comment

mcpowers Sep 20, 2023

Choose a reason for hiding this comment

valeriepeng commented Sep 20, 2023

mcpowers commented Sep 21, 2023

valeriepeng commented Sep 22, 2023

mcpowers commented Sep 28, 2023

valeriepeng commented Sep 28, 2023

openjdk bot commented Sep 28, 2023 • edited Loading

mcpowers commented Oct 2, 2023

mcpowers commented Oct 2, 2023

openjdk bot commented Oct 2, 2023

valeriepeng commented Oct 2, 2023

openjdk bot commented Oct 2, 2023

openjdk bot commented Oct 2, 2023

mcpowers commented Sep 8, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 8, 2023 •

edited

Loading

openjdk bot commented Sep 28, 2023 •

edited

Loading