Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314832: Few runtime/os tests ignore vm flags #15647

Closed

Conversation

mseledts
Copy link
Member

@mseledts mseledts commented Sep 8, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314832: Few runtime/os tests ignore vm flags (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15647/head:pull/15647
$ git checkout pull/15647

Update a local copy of the PR:
$ git checkout pull/15647
$ git pull https://git.openjdk.org/jdk.git pull/15647/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15647

View PR using the GUI difftool:
$ git pr show -t 15647

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15647.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2023

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@mseledts The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review labels Sep 8, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2023

Webrevs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test should also be marked vm.flagless. Running with additional flags, especially something like -Xcomp, could have an effect on the RSS usage that the test is trying to measure. Other flags really have no bearing on what is being tested here.

Copy link
Member Author

@mseledts mseledts Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David, thank you for advice. I will update the test to mark it "flagless".

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add flagless to the manual tests, but I'm not sure. I will leave it to you.

Thanks

@@ -40,6 +41,7 @@
* @bug 8303215 8312182
* @summary On THP=always systems, we prevent THPs from forming within thread stacks (negative test)
* @library /test/lib
* @requires vm.flagless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is needed here as this is a manual test

@@ -36,6 +37,7 @@

/*
* @test id=trimNativeStrict
* @requires vm.flagless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto perhaps not needed for a manual test

@@ -69,6 +73,7 @@
/*
* @test id=trimNativeLowIntervalStrict
* @summary Very low (sub-second) interval, nothing should explode (stricter test, manual mode)
* @requires vm.flagless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto manual test

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314832: Few runtime/os tests ignore vm flags

Reviewed-by: dholmes, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • d0be73a: 8041488: Locale-Dependent List Patterns
  • dd214d0: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • 877731d: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • d06a564: 8315765: G1: Incorrect use of G1LastPLABAverageOccupancy
  • 66b6a5a: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation
  • 4cb4637: 8315970: Big-endian issues after JDK-8310929
  • ae08143: 8315611: Open source swing text/html and tree test
  • 7b3e697: 8315855: G1: Revise signature of set_humongous_candidate
  • 1941290: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
  • 996b336: 8315781: Reduce the max value of GCDrainStackTargetSize
  • ... and 8 more: https://git.openjdk.org/jdk/compare/dccf6704925715e62dcbf84ac11930298913e173...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2023
@mseledts
Copy link
Member Author

Thank you David, Leonid.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

Going to push as commit fc3e826.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 347beb2: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
  • 50158f3: 8316002: Remove unnecessary seen_dead_loader in ClassLoaderDataGraph::do_unloading
  • 6f2684b: 8315948: JDK-8315818 broke Xcomp on libgraal
  • 8b4f9a8: 8315990: Amend problemlisted tests to proper position
  • 455c471: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code
  • 3b422d0: 8316094: Problemlist compiler/rangechecks/TestRangeCheckHoistingScaledIV.java
  • f55e799: 8316038: Fix doc typos in java.io.Console and java.util.Scanner
  • 9480078: 8315550: G1: Fix -Wconversion warnings in g1NUMA
  • d08258f: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases
  • fda142f: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • ... and 18 more: https://git.openjdk.org/jdk/compare/dccf6704925715e62dcbf84ac11930298913e173...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2023
@openjdk openjdk bot closed this Sep 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@mseledts Pushed as commit fc3e826.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants