8315532: Compiler Implementation for Unnamed Variables & Patterns #15649

biboudis · 2023-09-09T00:02:20Z

This PR finalizes the feature of unnamed variables and patterns.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8315851 to be approved
Change requires a JEP request to be targeted
Change requires CSR request JDK-8317222 to be approved

Issues

JDK-8315532: Compiler Implementation for Unnamed Variables & Patterns (Sub-task - P4)
JDK-8317221: Implementation for javax.lang.model for Unnamed Variables & Patterns (Sub-task - P4)
JDK-8311828: JEP 456: Unnamed Variables & Patterns (JEP)
JDK-8315851: Compiler Implementation for Unnamed Variables & Patterns (CSR)
JDK-8317222: Implementation for javax.lang.model for Unnamed Variables & Patterns (CSR)

Reviewers

Jan Lahoda (@lahodaj - Reviewer)
Maurizio Cimadamore (@mcimadamore - Reviewer) ⚠️ Review applies to 630b128e

Contributors

Jan Lahoda <jlahoda@openjdk.org>
Maurizio Cimadamore <mcimadamore@openjdk.org>
Gavin Bierman <gbierman@openjdk.org>
Brian Goetz <briangoetz@openjdk.org>
Joe Darcy <darcy@openjdk.org>
Aggelos Biboudis <abimpoudis@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15649/head:pull/15649
$ git checkout pull/15649

Update a local copy of the PR:
$ git checkout pull/15649
$ git pull https://git.openjdk.org/jdk.git pull/15649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15649

View PR using the GUI difftool:
$ git pr show -t 15649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15649.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-09-09T00:03:28Z

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-09-09T00:04:40Z

@biboudis The following labels will be automatically applied to this pull request:

compiler
core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-09-25T15:03:58Z

Webrevs

lahodaj

Overall, looks reasonable to me. A few comments/suggestions for your consideration inline.

test/langtools/tools/javac/lambda/IdentifierTest9.out

test/langtools/tools/javac/T8314423.java

test/langtools/tools/javac/diags/examples/UseOfUnderscoreNotAllowedWithBrackets.java

test/langtools/tools/javac/lambda/IdentifierTest.java

test/langtools/tools/javac/diags/examples/UnderscoreInLambdaExpression.java

test/langtools/tools/javac/diags/examples/UnderscoreAsIdentifierError.java

biboudis · 2023-09-28T09:04:03Z

/issue add JDK-8317221

openjdk · 2023-09-28T09:05:08Z

@biboudis
Adding additional issue to issue list: 8317221: Implementation for javax.lang.model for unnamed variables.

biboudis · 2023-10-05T11:33:22Z

/contributor add @lahodaj
/contributor add @mcimadamore
/contributor add @GavinBierman
/contributor add @briangoetz
/contributor add @jddarcy
/contributor add @biboudis

openjdk · 2023-10-05T11:34:20Z

@biboudis
Contributor Jan Lahoda <jlahoda@openjdk.org> successfully added.

openjdk · 2023-10-05T11:35:15Z

@biboudis
Contributor Maurizio Cimadamore <mcimadamore@openjdk.org> successfully added.

openjdk · 2023-10-05T11:36:33Z

@biboudis
Contributor Gavin Bierman <gbierman@openjdk.org> successfully added.

openjdk · 2023-10-05T11:37:47Z

@biboudis
Contributor Brian Goetz <briangoetz@openjdk.org> successfully added.

openjdk · 2023-10-05T11:38:54Z

@biboudis
Contributor Joe Darcy <darcy@openjdk.org> successfully added.

openjdk · 2023-10-05T11:39:52Z

@biboudis
Contributor Aggelos Biboudis <abimpoudis@openjdk.org> successfully added.

biboudis · 2023-10-18T21:33:16Z

/issue remove JDK-8317221

openjdk · 2023-10-18T21:34:04Z

@biboudis
Removing additional issue from issue list: 8317221.

biboudis · 2023-10-18T21:34:44Z

/issue add JDK-8317221

openjdk · 2023-10-18T21:35:48Z

@biboudis
Adding additional issue to issue list: 8317221: Implementation for javax.lang.model for Unnamed Variables & Patterns.

openjdk · 2023-10-20T02:01:43Z

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315532: Compiler Implementation for Unnamed Variables & Patterns
8317221: Implementation for javax.lang.model for Unnamed Variables & Patterns

Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Co-authored-by: Maurizio Cimadamore <mcimadamore@openjdk.org>
Co-authored-by: Gavin Bierman <gbierman@openjdk.org>
Co-authored-by: Brian Goetz <briangoetz@openjdk.org>
Co-authored-by: Joe Darcy <darcy@openjdk.org>
Co-authored-by: Aggelos Biboudis <abimpoudis@openjdk.org>
Reviewed-by: jlahoda, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

3934127: 8318709: Improve System.nanoTime performance on Windows
83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
ce0ca47: 8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode
db34025: 8318827: RISC-V: Improve readability of fclass result testing
1ec0d02: 8318225: RISC-V: C2 UModI
96bec35: 8316996: Catalog API Enhancement: add a factory method
d226014: 8318850: Duplicate code in the LCMSImageLayout
c593f8b: 8318091: Remove empty initIDs functions
... and 156 more: https://git.openjdk.org/jdk/compare/7c80cb26dfb6e90147f5f36d780457eff09e58ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lahodaj, @mcimadamore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

biboudis · 2023-10-23T08:05:00Z

/jep JEP-456

openjdk · 2023-10-23T08:05:51Z

@biboudis
This pull request will not be integrated until the JEP-456 has been targeted.

biboudis · 2023-10-30T09:19:23Z

/integrate

openjdk · 2023-10-30T09:20:46Z

@biboudis
Your change (at version bd43790) is now ready to be sponsored by a Committer.

lahodaj · 2023-10-30T10:28:00Z

/sponsor

openjdk · 2023-10-30T10:28:50Z

Going to push as commit c9d23c3.
Since your change was applied there have been 166 commits pushed to the master branch:

3934127: 8318709: Improve System.nanoTime performance on Windows
83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
ce0ca47: 8319067: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-aarch64 in Xcomp mode
db34025: 8318827: RISC-V: Improve readability of fclass result testing
1ec0d02: 8318225: RISC-V: C2 UModI
96bec35: 8316996: Catalog API Enhancement: add a factory method
d226014: 8318850: Duplicate code in the LCMSImageLayout
c593f8b: 8318091: Remove empty initIDs functions
... and 156 more: https://git.openjdk.org/jdk/compare/7c80cb26dfb6e90147f5f36d780457eff09e58ad...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-10-30T10:28:57Z

@lahodaj @biboudis Pushed as commit c9d23c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8315532: Compiler Implementation for Unnamed Variables and Patterns

d334ff2

openjdk bot added the csr Pull request needs approved CSR before integration label Sep 9, 2023

openjdk bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Sep 9, 2023

biboudis marked this pull request as ready for review September 25, 2023 14:56

openjdk bot added the rfr Pull request is ready for review label Sep 25, 2023

lahodaj reviewed Sep 25, 2023

View reviewed changes

biboudis added 2 commits September 26, 2023 16:35

Address review by @lahodaj

3becc94

Address review by @mcimadamore

630b128

mcimadamore approved these changes Sep 28, 2023

View reviewed changes

biboudis added 5 commits October 11, 2023 16:06

Merge branch 'master' into unnamed

bc79222

Add test with multi-catch

ccbfbd4

Merge branch 'master' into unnamed

13a4b6f

Merge branch 'master' into unnamed

067e358

Remove preview lines from a new .out file

bd43790

biboudis changed the title ~~8315532: Compiler Implementation for Unnamed Variables and Patterns~~ 8315532: Compiler Implementation for Unnamed Variables & Patterns Oct 18, 2023

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Oct 20, 2023

openjdk bot added jep ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated jep labels Oct 23, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 30, 2023

lahodaj approved these changes Oct 30, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Oct 30, 2023

openjdk bot closed this Oct 30, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8315532: Compiler Implementation for Unnamed Variables & Patterns #15649

8315532: Compiler Implementation for Unnamed Variables & Patterns #15649

biboudis commented Sep 9, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 9, 2023

openjdk bot commented Sep 9, 2023

mlbridge bot commented Sep 25, 2023 •

edited

Loading

lahodaj left a comment

biboudis commented Sep 28, 2023

openjdk bot commented Sep 28, 2023

biboudis commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

biboudis commented Oct 18, 2023

openjdk bot commented Oct 18, 2023

biboudis commented Oct 18, 2023

openjdk bot commented Oct 18, 2023

openjdk bot commented Oct 20, 2023 •

edited

Loading

biboudis commented Oct 23, 2023

openjdk bot commented Oct 23, 2023

biboudis commented Oct 30, 2023

openjdk bot commented Oct 30, 2023

lahodaj commented Oct 30, 2023

openjdk bot commented Oct 30, 2023

openjdk bot commented Oct 30, 2023

8315532: Compiler Implementation for Unnamed Variables & Patterns #15649

8315532: Compiler Implementation for Unnamed Variables & Patterns #15649

Conversation

biboudis commented Sep 9, 2023 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Contributors

Reviewing

Webrev

bridgekeeper bot commented Sep 9, 2023

openjdk bot commented Sep 9, 2023

mlbridge bot commented Sep 25, 2023 • edited Loading

Webrevs

lahodaj left a comment

Choose a reason for hiding this comment

biboudis commented Sep 28, 2023

openjdk bot commented Sep 28, 2023

biboudis commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

openjdk bot commented Oct 5, 2023

biboudis commented Oct 18, 2023

openjdk bot commented Oct 18, 2023

biboudis commented Oct 18, 2023

openjdk bot commented Oct 18, 2023

openjdk bot commented Oct 20, 2023 • edited Loading

biboudis commented Oct 23, 2023

openjdk bot commented Oct 23, 2023

biboudis commented Oct 30, 2023

openjdk bot commented Oct 30, 2023

lahodaj commented Oct 30, 2023

openjdk bot commented Oct 30, 2023

openjdk bot commented Oct 30, 2023

biboudis commented Sep 9, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 25, 2023 •

edited

Loading

openjdk bot commented Oct 20, 2023 •

edited

Loading