8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge

[mrserb]

The test tries to generate the OOM by filling the whole heap, unfortunately it may fail if the heap is large than 25G. If the heap is around 15-20G the test is quite slow.

The current patch is kind of modified version of the next fix, but instead of increasing timeout it minimize the amount of memory used by the heap.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge (Bug - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15676/head:pull/15676
$ git checkout pull/15676

Update a local copy of the PR:
$ git checkout pull/15676
$ git pull https://git.openjdk.org/jdk.git pull/15676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15676

View PR using the GUI difftool:
$ git pr show -t 15676

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15676.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (15986b4b)

[lmesnik]

Looks good and should be enough to don't fail with ZGC/SingelGenZGC.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge

Reviewed-by: lmesnik, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
• a9679ac: 8253620: Debug symbols for tests missing on macos and windows
• 020255a: 8267174: Many test files have the wrong Copyright header
• ac2dfe4: 8313865: Always true condition in sun.nio.cs.CharsetMapping#readINDEXC2B
• 947dee7: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest
• 1d702d2: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
• e084516: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication
• d75d977: 8285447: StackWalker minimal batch size should be optimized for getCallerClass
• fc3e826: 8314832: Few runtime/os tests ignore vm flags
• 347beb2: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
• ... and 9 more: https://git.openjdk.org/jdk/compare/d0be73a78038faf9509623bc4ba71eb4385cd645...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Looks good - all OOME inducing tests should set the heap size. And presumably it will also now run fast so doesn't need a custom timeout.

Thanks

[mrserb]

/integrate

[openjdk]

Going to push as commit bd52bbf.
Since your change was applied there have been 19 commits pushed to the master branch:

• dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
• a9679ac: 8253620: Debug symbols for tests missing on macos and windows
• 020255a: 8267174: Many test files have the wrong Copyright header
• ac2dfe4: 8313865: Always true condition in sun.nio.cs.CharsetMapping#readINDEXC2B
• 947dee7: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest
• 1d702d2: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
• e084516: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication
• d75d977: 8285447: StackWalker minimal batch size should be optimized for getCallerClass
• fc3e826: 8314832: Few runtime/os tests ignore vm flags
• 347beb2: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
• ... and 9 more: https://git.openjdk.org/jdk/compare/d0be73a78038faf9509623bc4ba71eb4385cd645...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit bd52bbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.