Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge #15676

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 12, 2023

The test tries to generate the OOM by filling the whole heap, unfortunately it may fail if the heap is large than 25G. If the heap is around 15-20G the test is quite slow.

The current patch is kind of modified version of the next fix, but instead of increasing timeout it minimize the amount of memory used by the heap.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15676/head:pull/15676
$ git checkout pull/15676

Update a local copy of the PR:
$ git checkout pull/15676
$ git pull https://git.openjdk.org/jdk.git pull/15676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15676

View PR using the GUI difftool:
$ git pr show -t 15676

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15676.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@mrserb The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 12, 2023
@mrserb mrserb marked this pull request as ready for review September 12, 2023 20:28
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2023

Webrevs

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and should be enough to don't fail with ZGC/SingelGenZGC.

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge

Reviewed-by: lmesnik, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
  • a9679ac: 8253620: Debug symbols for tests missing on macos and windows
  • 020255a: 8267174: Many test files have the wrong Copyright header
  • ac2dfe4: 8313865: Always true condition in sun.nio.cs.CharsetMapping#readINDEXC2B
  • 947dee7: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest
  • 1d702d2: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • e084516: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication
  • d75d977: 8285447: StackWalker minimal batch size should be optimized for getCallerClass
  • fc3e826: 8314832: Few runtime/os tests ignore vm flags
  • 347beb2: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
  • ... and 9 more: https://git.openjdk.org/jdk/compare/d0be73a78038faf9509623bc4ba71eb4385cd645...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2023
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - all OOME inducing tests should set the heap size. And presumably it will also now run fast so doesn't need a custom timeout.

Thanks

@mrserb
Copy link
Member Author

mrserb commented Sep 13, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit bd52bbf.
Since your change was applied there have been 19 commits pushed to the master branch:

  • dde1155: 8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern
  • a9679ac: 8253620: Debug symbols for tests missing on macos and windows
  • 020255a: 8267174: Many test files have the wrong Copyright header
  • ac2dfe4: 8313865: Always true condition in sun.nio.cs.CharsetMapping#readINDEXC2B
  • 947dee7: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest
  • 1d702d2: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • e084516: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication
  • d75d977: 8285447: StackWalker minimal batch size should be optimized for getCallerClass
  • fc3e826: 8314832: Few runtime/os tests ignore vm flags
  • 347beb2: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
  • ... and 9 more: https://git.openjdk.org/jdk/compare/d0be73a78038faf9509623bc4ba71eb4385cd645...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@mrserb Pushed as commit bd52bbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8316060 branch October 19, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants