Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315834: Open source several Swing JSpinner related tests #15678

Closed
wants to merge 3 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Sep 12, 2023

Open source these Swing JSpinner related tests:

javax/swing/JSpinner/4522737/bug4522737.java
javax/swing/JSpinner/4656590/bug4656590.java
javax/swing/JSpinner/4680204/bug4680204.java
javax/swing/JSpinner/4862257/bug4862257.java
javax/swing/JSpinner/5104421/bug5104421.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315834: Open source several Swing JSpinner related tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15678/head:pull/15678
$ git checkout pull/15678

Update a local copy of the PR:
$ git checkout pull/15678
$ git pull https://git.openjdk.org/jdk.git pull/15678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15678

View PR using the GUI difftool:
$ git pr show -t 15678

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15678.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2023

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 12, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2023

Webrevs

test/jdk/javax/swing/JSpinner/bug4522737.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JSpinner/bug4680204.java Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315834: Open source several Swing JSpinner related tests

Reviewed-by: psadhukhan, abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 559 new commits pushed to the master branch:

  • 14408bc: 8315973: Remove unused fields from ThreadLocalRandom
  • 903b9e8: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.
  • 639ba13: 8316179: Use consistent naming for lightweight locking in MacroAssembler
  • 11d431b: 8316228: jcmd tests are broken by 8314828
  • eb37c7e: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • 23fab11: 8314828: Mark 3 jcmd command-line options test as vm.flagless
  • 1741d13: 8315726: Open source several AWT applet tests
  • 92ad4a2: 8315789: Minor HexFormat performance improvements
  • ce93d27: 6228794: java.text.ChoiceFormat pattern behavior is not well documented.
  • 3b0a6d2: 8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly
  • ... and 549 more: https://git.openjdk.org/jdk/compare/86821a7ce89c51cc3650228c55a4a88c743209e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2023
Copy link
Contributor

@kumarabhi006 kumarabhi006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming you have run the CI tests after moving to open repo.

@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

Going to push as commit 4a63eb0.
Since your change was applied there have been 582 commits pushed to the master branch:

  • 8dc2d92: 8316190: Improve MemorySegment::toString
  • 783e44d: 8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again
  • 96781ba: 8312332: C2: Refactor SWPointer out from SuperWord
  • b55e418: 8301991: Convert l10n properties resource bundles to UTF-8 native
  • d475f61: 8315731: Open source several Swing Text related tests
  • 4415261: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • b2e9106: 8313452: Improve Classfile API attributes handling safety
  • 2a6fb9c: 8316147: Remove serviceability/sa/TestJhsdbJstackMixed.java from -Xcomp problem list
  • ca747f0: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing
  • 6d47fc6: 8313258: RuntimeInvisibleTypeAnnotationsAttribute.annotations() API Index out of Bound error
  • ... and 572 more: https://git.openjdk.org/jdk/compare/86821a7ce89c51cc3650228c55a4a88c743209e4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2023
@openjdk openjdk bot closed this Sep 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@TejeshR13 Pushed as commit 4a63eb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants