New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8026976: ECParameters, Point does not match field size #1568
Conversation
👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into |
@ascarpino The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
if (!token.config.getUseEcX963Encoding()) { | ||
point = decodePoint(new DerValue(attributes[0].getByteArray()).getOctetString(), params.getCurve()); | ||
} else { | ||
point = decodePoint(attributes[0].getByteArray(), params.getCurve()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could save a "!" operation in 299 if switch line 302 and line 300.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only used "!" for consistency with existing usage in P11Key.java:1080. Is there a reason to avoid "!" other than maybe readability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Save a operation could get a little bit performance. Comparing to "if (!a)", "if (a)" is easier to read to me, and save me a cycle to compute the "!". Anyway, not a big concern of mine, you can leave it as is if you prefer the "if (!a)" style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to finish up the thought. The assembly instructions are the same using if(!a) or if(a). The difference would be how the code is setup during compile time and I believe that would be the same speed as well..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the check. It looks good to me and I have no more comment.
@ascarpino This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 45 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@ascarpino Since your change was applied there have been 47 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 55f5542. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I need a code review for this small code change. The code did not run the data through the DER decoding class before setting it to the point when the SunPKCS11 configuration had UseEcX963Encoding set to false.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1568/head:pull/1568
$ git checkout pull/1568