8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV

[zifeihan]

Hi, This patch fixes an error when qemu enabled the parameter rvv_ta_all_1s=true. The cause for the error is that the number of set lanes here may be smaller than Matcher::vector_length(this), then this vector width is not set correctly. this in turn causes the width of the returned vector length to be less than the expected length. together with these two options for QEMU, this resulted in the use of unintended vector element values.

jdk/src/hotspot/cpu/riscv/riscv_v.ad

Line 3510 in 9480078

__ vsetvli(t0, $tmp$$Register, sew);

Testing:

qemu with UseRVV:

• test/jdk/jdk/incubator/vector (fastdebug)

qemu with rvv_ma_all_1s=true,rvv_ta_all_1s=true and UseRVV:

• Tier1 tests (release)
• Tier2 tests (release)
• Tier3 tests (release)
• test/jdk/jdk/incubator/vector (fastdebug)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Dingli Zhang (@DingliZhang - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15680/head:pull/15680
$ git checkout pull/15680

Update a local copy of the PR:
$ git checkout pull/15680
$ git pull https://git.openjdk.org/jdk.git pull/15680/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15680

View PR using the GUI difftool:
$ git pr show -t 15680

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15680.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5599fb25)

[RealFYang]

Looks reasonable to me. @robehn : Could you please help verify if this will also work in your test setup? Thanks.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV

Reviewed-by: fyang, dzhang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

• d575968: 8316178: Better diagnostic header for CodeBlobs
• bfbc41c: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 0775bf2: 8316106: Open source few swing JInternalFrame and JMenuBar tests
• 4a63eb0: 8315834: Open source several Swing JSpinner related tests
• 8dc2d92: 8316190: Improve MemorySegment::toString
• 783e44d: 8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again
• 96781ba: 8312332: C2: Refactor SWPointer out from SuperWord
• b55e418: 8301991: Convert l10n properties resource bundles to UTF-8 native
• d475f61: 8315731: Open source several Swing Text related tests
• 4415261: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
• ... and 61 more: https://git.openjdk.org/jdk/compare/fda142ff6cfefa12ec1ea4d4eb48b3c1b285bc04...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[robehn]

Looks reasonable to me. @robehn : Could you please help verify if this will also work in your test setup? Thanks.

I can no longer reproduce with this patch applied.
Thanks for the patch and quick turn around!

[DingliZhang]

LGTM, thanks!

[zifeihan]

@RealFYang @robehn @DingliZhang thanks all for the review.
/integrate

[openjdk]

@zifeihan
Your change (at version 5599fb2) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 4070829.
Since your change was applied there have been 71 commits pushed to the master branch:

• d575968: 8316178: Better diagnostic header for CodeBlobs
• bfbc41c: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 0775bf2: 8316106: Open source few swing JInternalFrame and JMenuBar tests
• 4a63eb0: 8315834: Open source several Swing JSpinner related tests
• 8dc2d92: 8316190: Improve MemorySegment::toString
• 783e44d: 8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again
• 96781ba: 8312332: C2: Refactor SWPointer out from SuperWord
• b55e418: 8301991: Convert l10n properties resource bundles to UTF-8 native
• d475f61: 8315731: Open source several Swing Text related tests
• 4415261: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
• ... and 61 more: https://git.openjdk.org/jdk/compare/fda142ff6cfefa12ec1ea4d4eb48b3c1b285bc04...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit 4070829.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.