Skip to content

Conversation

@luhenry
Copy link
Member

@luhenry luhenry commented Sep 12, 2023

Conservative fences are not a requirement on some RISC-V hardware for correctness, but can bring a performance penalty. Let's make sure we disable them on a per-vendor basis, and keep them enabled for the default case.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315934: RISC-V: Disable conservative fences per vendor (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15684/head:pull/15684
$ git checkout pull/15684

Update a local copy of the PR:
$ git checkout pull/15684
$ git pull https://git.openjdk.org/jdk.git pull/15684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15684

View PR using the GUI difftool:
$ git pr show -t 15684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15684.diff

Webrev

Link to Webrev Comment

Conservative fences are not a requirement on some RISC-V hardware for correctness, but can bring a performance penalty. Let's make sure we disable them on a per-vendor basis, and keep them enabled for the default case.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2023

👋 Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@luhenry The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 12, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2023

Webrevs

Copy link
Contributor

@robehn robehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable when looking at other platforms vm versions.

You may consider turn off ztso if someone really wants a lot of extra fencing :)

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@luhenry This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315934: RISC-V: Disable conservative fences per vendor

Reviewed-by: rehn, mli, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2023
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's keep the current shape. Please ignore my previous comment.

@luhenry
Copy link
Member Author

luhenry commented Sep 13, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit a731a24.
Since your change was applied there have been 56 commits pushed to the master branch:

  • b3dad24: 8316021: Serial: Remove unused Generation::post_compact
  • f9ab115: 8316050: Use hexadecimal encoding in MemorySegment::toString
  • f804f86: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector
  • f8df754: 8311207: Cleanup for Optimization for UUID.toString
  • fecd2fd: 8315898: Open source swing JMenu tests
  • bb6b3f2: 8315761: Open source few swing JList and JMenuBar tests
  • 2d168c5: 8313202: MutexLocker should disallow null Mutexes
  • 36552e7: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
  • fe5ef5f: 8315677: Open source few swing JFileChooser and other tests
  • ece9bdf: 8299614: Shenandoah: STW mark should keep nmethod/oops referenced from stack chunk alive
  • ... and 46 more: https://git.openjdk.org/jdk/compare/b3dfc399dae714958f22624daf76831c6ec2dfe0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@luhenry Pushed as commit a731a24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants