Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8315889: Open source several Swing HTMLDocument related tests #15687

Closed
wants to merge 2 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Sep 12, 2023

Following tests are being open sourced as part of this PR.

javax/swing/text/html/HTMLDocument/4251593/bug4251593.java
javax/swing/text/html/HTMLDocument/4687405/bug4687405.java
javax/swing/text/html/HTMLDocument/4226914/bug4226914.java
javax/swing/text/html/HTMLEditorKit/4213373/bug4213373.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315889: Open source several Swing HTMLDocument related tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15687/head:pull/15687
$ git checkout pull/15687

Update a local copy of the PR:
$ git checkout pull/15687
$ git pull https://git.openjdk.org/jdk.git pull/15687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15687

View PR using the GUI difftool:
$ git pr show -t 15687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15687.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2023

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 12, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2023

Webrevs

@@ -0,0 +1,72 @@
/*
* Copyright (c) 1999, 2023, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315889: Open source several Swing HTMLDocument related tests

Reviewed-by: tr, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 186 new commits pushed to the master branch:

  • 0050447: 8316148: Remove sun/tools/jhsdb/JStackStressTest.java from problem list
  • 149acd1: 8316207: Fix typos in java.io.StreamTokenizer
  • dc5ca1d: 8316031: SSLFlowDelegate should not log from synchronized block
  • 8dfde28: 8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java
  • 3c743cf: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • bd26813: 8316295: Serial: Remove empty Generation::promotion_failure_occurred
  • 42dc6b5: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
  • 89cb290: 8312165: Fix typos in java.desktop Swing
  • 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
  • ... and 176 more: https://git.openjdk.org/jdk/compare/4f90abaf17716493bad740dcef76d49f16d69379...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 14, 2023
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

Going to push as commit 8f46abc.
Since your change was applied there have been 186 commits pushed to the master branch:

  • 0050447: 8316148: Remove sun/tools/jhsdb/JStackStressTest.java from problem list
  • 149acd1: 8316207: Fix typos in java.io.StreamTokenizer
  • dc5ca1d: 8316031: SSLFlowDelegate should not log from synchronized block
  • 8dfde28: 8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java
  • 3c743cf: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • bd26813: 8316295: Serial: Remove empty Generation::promotion_failure_occurred
  • 42dc6b5: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
  • 89cb290: 8312165: Fix typos in java.desktop Swing
  • 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
  • ... and 176 more: https://git.openjdk.org/jdk/compare/4f90abaf17716493bad740dcef76d49f16d69379...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2023
@openjdk openjdk bot closed this Sep 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@honkar-jdk Pushed as commit 8f46abc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants