Skip to content

8257622: MemoryAccess methods are missing @ForceInline annotations #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

8257622: MemoryAccess methods are missing @ForceInline annotations #1570

wants to merge 3 commits into from

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Dec 2, 2020 •
edited by openjdk bot
Loading

The accessor methods in the MemoryAccess class are missing @ForceInline annotations. This causes odd behavior on certain benchmarks, especially if these methods are called many times in the body of a single method.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257622: MemoryAccess methods are missing @ForceInline annotations

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1570/head:pull/1570
$ git checkout pull/1570

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2020

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2020
@openjdk
Copy link

openjdk bot commented Dec 2, 2020

@mcimadamore The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 2, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2020 •
edited
Loading

Webrevs

shipilev
shipilev approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with minor nit.

test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstantFP.java Outdated
unsafe_addrIn = unsafe.allocateMemory(ALLOC_SIZE);
unsafe_addrOut = unsafe.allocateMemory(ALLOC_SIZE);
for (int i = 0; i < ELEM_SIZE; i++) {
unsafe.putDouble(unsafe_addrIn + (i * CARRIER_SIZE) , i);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and later, excess whitespace before final comma.

@openjdk
Copy link

openjdk bot commented Dec 3, 2020 •
edited
Loading

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257622: MemoryAccess methods are missing @ForceInline annotations

Reviewed-by: jvernee, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • feabdde: 8251843: jfr/tool/TestPrintJSON.java fails intermittently
  • c6f93ec: 8257707: Fix incorrect format string in Http1HeaderParser
  • fbdc187: 8257624: C2: PhaseMacroExpand::eliminate_macro_nodes() crashes on out-of-bounds access into macro node array
  • fd6756e: 8257634: C2: Introduce IncrementalInliningForceCleanup diagnostic flag
  • af6b7f9: 8257743: Minimal build on AArch64 failed with --disable-precompiled-headers
  • d6dd440: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 2b4a423: 8255542: Attribute length of Module, ModulePackages and other attributes is ignored
  • ca40267: 8257509: Strengthen requirements to call G1HeapVerifier::verify(VerifyOption)
  • 4a85514: 8257182: JCK test failures in integer / long rotation tests
  • f33808f: 8257631: C2: Assertion failure in ArrayCopyNode::get_count() during late inlining
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/0b8c7807fe9381bf812ea5ae0ae051a46f35b6d8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2020
@mcimadamore
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Dec 4, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@mcimadamore Since your change was applied there have been 51 commits pushed to the master branch:

  • 1d2d981: 8257423: [PPC64] Support -XX:-UseInlineCaches
  • feabdde: 8251843: jfr/tool/TestPrintJSON.java fails intermittently
  • c6f93ec: 8257707: Fix incorrect format string in Http1HeaderParser
  • fbdc187: 8257624: C2: PhaseMacroExpand::eliminate_macro_nodes() crashes on out-of-bounds access into macro node array
  • fd6756e: 8257634: C2: Introduce IncrementalInliningForceCleanup diagnostic flag
  • af6b7f9: 8257743: Minimal build on AArch64 failed with --disable-precompiled-headers
  • d6dd440: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 2b4a423: 8255542: Attribute length of Module, ModulePackages and other attributes is ignored
  • ca40267: 8257509: Strengthen requirements to call G1HeapVerifier::verify(VerifyOption)
  • 4a85514: 8257182: JCK test failures in integer / long rotation tests
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/0b8c7807fe9381bf812ea5ae0ae051a46f35b6d8...master

Your commit was automatically rebased without conflicts.

Pushed as commit dede01e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shipilev shipilev shipilev approved these changes

@JornVernee JornVernee JornVernee approved these changes

@Nrakron Nrakron Nrakron approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcimadamore @shipilev @JornVernee @Nrakron