-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316159: Update BoxLayout sample image for crisper edges #15703
8316159: Update BoxLayout sample image for crisper edges #15703
Conversation
Move all rectangles half a pixel to make edges crisp.
/summary Move all rectangles half a pixel to make edges crisp |
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
@aivanov-jdk Setting summary to |
@aivanov-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 161 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 3481ecb.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk Pushed as commit 3481ecb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Problem
On a standard display with the scale of 100%, the BoxLayout sample has blurred edges.
It is the result of how SVG is rendered: the strokes fall between the pixel grid, therefore a 1-pixel wide stroke is blurred between the previous and the following pixels with 50% of colour on each pixel. It doesn't look as good.
Fix
Move all rectangles half a pixel to make edges crisp. The edges of the rectangles look crisp in 100% and 200%.
For more information see answers to the following questions on Stack Overflow:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15703/head:pull/15703
$ git checkout pull/15703
Update a local copy of the PR:
$ git checkout pull/15703
$ git pull https://git.openjdk.org/jdk.git pull/15703/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15703
View PR using the GUI difftool:
$ git pr show -t 15703
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15703.diff
Webrev
Link to Webrev Comment