Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316159: Update BoxLayout sample image for crisper edges #15703

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 13, 2023

Problem

On a standard display with the scale of 100%, the BoxLayout sample has blurred edges.

It is the result of how SVG is rendered: the strokes fall between the pixel grid, therefore a 1-pixel wide stroke is blurred between the previous and the following pixels with 50% of colour on each pixel. It doesn't look as good.

Fix

Move all rectangles half a pixel to make edges crisp. The edges of the rectangles look crisp in 100% and 200%.

For more information see answers to the following questions on Stack Overflow:


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316159: Update BoxLayout sample image for crisper edges (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15703/head:pull/15703
$ git checkout pull/15703

Update a local copy of the PR:
$ git checkout pull/15703
$ git pull https://git.openjdk.org/jdk.git pull/15703/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15703

View PR using the GUI difftool:
$ git pr show -t 15703

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15703.diff

Webrev

Link to Webrev Comment

Move all rectangles half a pixel to make edges crisp.
@aivanov-jdk
Copy link
Member Author

/summary Move all rectangles half a pixel to make edges crisp

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@aivanov-jdk Setting summary to Move all rectangles half a pixel to make edges crisp

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 13, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

@aivanov-jdk aivanov-jdk changed the title 8316159: Update BoxLayout sample image for crispier edges 8316159: Update BoxLayout sample image for crisper edges Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316159: Update BoxLayout sample image for crisper edges

Move all rectangles half a pixel to make edges crisp

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 161 new commits pushed to the master branch:

  • c90d631: 8315750: Update subtype check profile collection on PPC following 8308869
  • 00f585b: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
  • bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
  • 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
  • a1e0346: 8316698: build failure caused by JDK-8316456
  • ... and 151 more: https://git.openjdk.org/jdk/compare/fecd2fd8f26d0e8905a519e30e9aa171683c9df1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2023
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit 3481ecb.
Since your change was applied there have been 228 commits pushed to the master branch:

  • 7981251: 8316970: Add internal annotation to mark restricted methods
  • 77fac0f: 8316906: Clarify TLABWasteTargetPercent flag
  • 2d154fc: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 42924ed: 8316946: jtreg failure handler pages are mislabelling the jcmd/thread/dump_to_file results.
  • 384d2ea: 8316125: Windows call_stub unnecessarily saves xmm16-31 when UseAVX>=3
  • 84390dd: 8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently
  • 52073b2: 8316994: Avoid modifying ClassLoader and Module objects during -Xshare:dump
  • 83c0e45: 8306630: Bump minimum boot jdk to JDK 21
  • d3a79b5: 8316371: Open some swing tests 6
  • 750da00: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • ... and 218 more: https://git.openjdk.org/jdk/compare/fecd2fd8f26d0e8905a519e30e9aa171683c9df1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@aivanov-jdk Pushed as commit 3481ecb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8316159-BoxLayout-crispEdges branch September 28, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants