Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315669: Open source several Swing PopupMenu related tests #15704

Closed
wants to merge 5 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Sep 13, 2023

Open source these Swing PopupMenu related tests:

javax/swing/JPopupMenu/4236750/bug4236750.java
javax/swing/JPopupMenu/4321273/bug4321273.java
javax/swing/JPopupMenu/4711693/bug4711693.java
javax/swing/JPopupMenu/4962731/bug4962731.java
javax/swing/JPopupMenu/4966109/bug4966109.java
javax/swing/JPopupMenu/5091257/bug5091257.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315669: Open source several Swing PopupMenu related tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15704/head:pull/15704
$ git checkout pull/15704

Update a local copy of the PR:
$ git checkout pull/15704
$ git pull https://git.openjdk.org/jdk.git pull/15704/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15704

View PR using the GUI difftool:
$ git pr show -t 15704

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15704.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 13, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. One minor nit capitalization inconsistency

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315669: Open source several Swing PopupMenu related tests

Reviewed-by: dnguyen, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 624 new commits pushed to the master branch:

  • 138542d: 8316061: Open source several Swing RootPane and Slider related tests
  • f52e500: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • 3760a04: 8314021: HeapDump: Optimize segmented heap file merging phase
  • f226ceb: 8316440: LambdasInTwoArchives.java failed to find WhiteBox.class
  • 24c3d86: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests
  • 373e37b: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set
  • 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model
  • dcea9bf: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 1b104b6: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • 4421951: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • ... and 614 more: https://git.openjdk.org/jdk/compare/86821a7ce89c51cc3650228c55a4a88c743209e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 19, 2023
@TejeshR13
Copy link
Contributor Author

/integrate

1 similar comment
@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

Going to push as commit 7c5f2a2.
Since your change was applied there have been 631 commits pushed to the master branch:

  • cf74b8c: 8316337: (bf) Concurrency issue in DirectByteBuffer.Deallocator
  • 4461eeb: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked
  • 670b456: 8315038: Capstone disassembler stops when it sees a bad instruction
  • fab372d: 8316428: G1: Nmethod count statistics only count last code root set iterated
  • 283c360: 8314877: Make fields final in 'java.net' package
  • 86115c2: 8316420: Serial: Remove unused GenCollectedHeap::oop_iterate
  • d038571: 8030815: Code roots are not accounted for in region prediction
  • 138542d: 8316061: Open source several Swing RootPane and Slider related tests
  • f52e500: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • 3760a04: 8314021: HeapDump: Optimize segmented heap file merging phase
  • ... and 621 more: https://git.openjdk.org/jdk/compare/86821a7ce89c51cc3650228c55a4a88c743209e4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2023
@openjdk openjdk bot closed this Sep 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@TejeshR13 Pushed as commit 7c5f2a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@TejeshR13 The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants