Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved #15714

Closed
wants to merge 1 commit into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Sep 13, 2023

Hi, please consider.
Inspired by JDK-8313800. RISC-V also treats x8/fp as a callee-saved scratch register for some time, and it is freely used by C2-generated code. Therefore, any code in SA that uses getFP() in a compiled frame is very likely to come to grief.

Testing:

  • hotspot_serviceability
  • jdk_svc
  • tier1

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15714/head:pull/15714
$ git checkout pull/15714

Update a local copy of the PR:
$ git checkout pull/15714
$ git pull https://git.openjdk.org/jdk.git pull/15714/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15714

View PR using the GUI difftool:
$ git pr show -t 15714

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15714.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@feilongjiang The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 13, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 83dca62: 8313638: Add test for dump of resolved references
  • cfa8901: 8315338: RISC-V: Change flags for stable extensions to non-experimental
  • edd454b: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • de9b971: 8315933: Serial: Remove empty Generation::ensure_parsability
  • b48dbf6: 8316181: Move the fast locking implementation out of the .ad files
  • 8f4dfc4: 8316164: Opensource JMenuBar manual test
  • 33c62e4: 8316154: Opensource JTextArea manual tests
  • 14408bc: 8315973: Remove unused fields from ThreadLocalRandom
  • 903b9e8: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.
  • 639ba13: 8316179: Use consistent naming for lightweight locking in MacroAssembler
  • ... and 11 more: https://git.openjdk.org/jdk/compare/f804f8652da71b18cc654c08c12d07d6fd43c2a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 14, 2023
@feilongjiang
Copy link
Member Author

@RealFYang -- Thanks!
/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

Going to push as commit 42dc6b5.
Since your change was applied there have been 47 commits pushed to the master branch:

  • 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
  • 89cb290: 8312165: Fix typos in java.desktop Swing
  • 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
  • 86dde5e: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
  • 4f864fa: 8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations
  • 4070829: 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV
  • d575968: 8316178: Better diagnostic header for CodeBlobs
  • bfbc41c: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
  • 0775bf2: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • 4a63eb0: 8315834: Open source several Swing JSpinner related tests
  • ... and 37 more: https://git.openjdk.org/jdk/compare/f804f8652da71b18cc654c08c12d07d6fd43c2a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2023
@openjdk openjdk bot closed this Sep 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@feilongjiang Pushed as commit 42dc6b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants