Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows. #15719

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Sep 13, 2023

Original failure in 8081569 is a long time ago, and not reproducing.
Other failures recorded there may be different problems, some of them are port related which are helped by other changes since these tests were problemlisted.

This problemlist entry should be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows. (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15719/head:pull/15719
$ git checkout pull/15719

Update a local copy of the PR:
$ git checkout pull/15719
$ git pull https://git.openjdk.org/jdk.git pull/15719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15719

View PR using the GUI difftool:
$ git pr show -t 15719

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15719.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinjwalls kevinjwalls marked this pull request as ready for review September 13, 2023 14:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@kevinjwalls To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@kevinjwalls
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@kevinjwalls
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.

Reviewed-by: lmesnik, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 92ad4a2: 8315789: Minor HexFormat performance improvements
  • ce93d27: 6228794: java.text.ChoiceFormat pattern behavior is not well documented.
  • 3b0a6d2: 8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly
  • ff240a9: 8316087: Test SignedLoggerFinderTest.java is still failing
  • a731a24: 8315934: RISC-V: Disable conservative fences per vendor
  • b3dad24: 8316021: Serial: Remove unused Generation::post_compact
  • f9ab115: 8316050: Use hexadecimal encoding in MemorySegment::toString

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2023
@kevinjwalls
Copy link
Contributor Author

Thanks Leonid, Chris!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

Going to push as commit 903b9e8.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 639ba13: 8316179: Use consistent naming for lightweight locking in MacroAssembler
  • 11d431b: 8316228: jcmd tests are broken by 8314828
  • eb37c7e: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • 23fab11: 8314828: Mark 3 jcmd command-line options test as vm.flagless
  • 1741d13: 8315726: Open source several AWT applet tests
  • 92ad4a2: 8315789: Minor HexFormat performance improvements
  • ce93d27: 6228794: java.text.ChoiceFormat pattern behavior is not well documented.
  • 3b0a6d2: 8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly
  • ff240a9: 8316087: Test SignedLoggerFinderTest.java is still failing
  • a731a24: 8315934: RISC-V: Disable conservative fences per vendor
  • ... and 2 more: https://git.openjdk.org/jdk/compare/f804f8652da71b18cc654c08c12d07d6fd43c2a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 14, 2023
@openjdk openjdk bot closed this Sep 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@kevinjwalls Pushed as commit 903b9e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants