-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315981: Opensource five more random Swing tests #15724
Conversation
Clean up and open source five tests: javax/swing/DefaultListCellRenderer/4180943/bug4180943.java javax/swing/DefaultListModel/4466250/bug4466250.java javax/swing/DefaultListSelectionModel/4140619/bug4140619.java javax/swing/DefaultListSelectionModel/4177723/bug4177723.java javax/swing/ImageIcon/4827074/bug4827074.java
👋 Welcome back kizune! A progress list of the required criteria for merging this PR into |
@azuev-java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
} catch (Exception ex) { | ||
ex.printStackTrace(); | ||
} | ||
return _ii; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the return value is not used.
synchronized static void setPassed(boolean p) { | ||
passed = p; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just set passed
to true directly on the line 100?
|
||
public class bug4180943 { | ||
public static void main(String[] argv) { | ||
DefaultListCellRenderer lcr1 = new DefaultListCellRenderer(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case not critical to the test, but I think it would be a good example for others to perform Swing related code on EDT.
(applicable to all tests).
@azuev-java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 182 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit c43ebd3.
Your commit was automatically rebased without conflicts. |
@azuev-java Pushed as commit c43ebd3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean up and open source five tests:
javax/swing/DefaultListCellRenderer/4180943/bug4180943.java
javax/swing/DefaultListModel/4466250/bug4466250.java
javax/swing/DefaultListSelectionModel/4140619/bug4140619.java
javax/swing/DefaultListSelectionModel/4177723/bug4177723.java
javax/swing/ImageIcon/4827074/bug4827074.java
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15724/head:pull/15724
$ git checkout pull/15724
Update a local copy of the PR:
$ git checkout pull/15724
$ git pull https://git.openjdk.org/jdk.git pull/15724/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15724
View PR using the GUI difftool:
$ git pr show -t 15724
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15724.diff
Webrev
Link to Webrev Comment