Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315981: Opensource five more random Swing tests #15724

Closed
wants to merge 2 commits into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Sep 13, 2023

Clean up and open source five tests:
javax/swing/DefaultListCellRenderer/4180943/bug4180943.java
javax/swing/DefaultListModel/4466250/bug4466250.java
javax/swing/DefaultListSelectionModel/4140619/bug4140619.java
javax/swing/DefaultListSelectionModel/4177723/bug4177723.java
javax/swing/ImageIcon/4827074/bug4827074.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315981: Opensource five more random Swing tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15724/head:pull/15724
$ git checkout pull/15724

Update a local copy of the PR:
$ git checkout pull/15724
$ git pull https://git.openjdk.org/jdk.git pull/15724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15724

View PR using the GUI difftool:
$ git pr show -t 15724

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15724.diff

Webrev

Link to Webrev Comment

Clean up and open source five tests:
javax/swing/DefaultListCellRenderer/4180943/bug4180943.java
javax/swing/DefaultListModel/4466250/bug4466250.java
javax/swing/DefaultListSelectionModel/4140619/bug4140619.java
javax/swing/DefaultListSelectionModel/4177723/bug4177723.java
javax/swing/ImageIcon/4827074/bug4827074.java
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 13, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
} catch (Exception ex) {
ex.printStackTrace();
}
return _ii;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the return value is not used.

Comment on lines +53 to +55
synchronized static void setPassed(boolean p) {
passed = p;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just set passed to true directly on the line 100?


public class bug4180943 {
public static void main(String[] argv) {
DefaultListCellRenderer lcr1 = new DefaultListCellRenderer();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case not critical to the test, but I think it would be a good example for others to perform Swing related code on EDT.
(applicable to all tests).

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315981: Opensource five more random Swing tests

Reviewed-by: tr, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 182 new commits pushed to the master branch:

  • 373e37b: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set
  • 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model
  • dcea9bf: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 1b104b6: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • 4421951: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • f09b7af: 8311220: Optimization for StringLatin UpperLower
  • 2e2d49c: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • bf9d1e2: 8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX
  • 21c2dac: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
  • ecce2af: 8316357: Serial: Remove unused GenCollectedHeap::space_containing
  • ... and 172 more: https://git.openjdk.org/jdk/compare/cef9fff0675c85906e134e4c0a8d2036860cd4b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2023
@azuev-java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

Going to push as commit c43ebd3.
Since your change was applied there have been 215 commits pushed to the master branch:

  • e30e356: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • 242eeae: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • b275bdd: 8308995: Update Network IO JFR events to be static mirror events
  • e1870d3: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
  • ec74194: 8316546: Backout JDK-8315932: runtime/InvocationTests spend a lot of time on dependency verification
  • 2568188: 8316547: Use JUnit.dir jtreg property with jpackage JUnit tests
  • 833a828: 8315876: Open source several Swing CSS related tests
  • 7ce5bd1: 8316468: os::write incorrectly handles partial write
  • d19e017: 8315951: Open source several Swing HTMLEditorKit related tests
  • 62c0a1b: 8315883: Open source several Swing JToolbar tests
  • ... and 205 more: https://git.openjdk.org/jdk/compare/cef9fff0675c85906e134e4c0a8d2036860cd4b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2023
@openjdk openjdk bot closed this Sep 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@azuev-java Pushed as commit c43ebd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants