Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Sep 14, 2023

Trivial removing redundant code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316295: Serial: Remove empty Generation::promotion_failure_occurred (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15744/head:pull/15744
$ git checkout pull/15744

Update a local copy of the PR:
$ git checkout pull/15744
$ git pull https://git.openjdk.org/jdk.git pull/15744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15744

View PR using the GUI difftool:
$ git pr show -t 15744

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15744.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8316295 8316295: Serial: Remove empty Generation::promotion_failure_occurred Sep 14, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 14, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316295: Serial: Remove empty Generation::promotion_failure_occurred

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 14, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

Going to push as commit bd26813.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 42dc6b5: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
  • 89cb290: 8312165: Fix typos in java.desktop Swing
  • 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
  • 86dde5e: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
  • 4f864fa: 8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations
  • 4070829: 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV
  • d575968: 8316178: Better diagnostic header for CodeBlobs
  • bfbc41c: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
  • 0775bf2: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • ... and 20 more: https://git.openjdk.org/jdk/compare/de9b971c2e21d01586c15ad87c33dd8f24e64e29...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2023
@openjdk openjdk bot closed this Sep 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@albertnetymk Pushed as commit bd26813.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-promo-fail branch September 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants