8312126: NullPointerException in CertStore.getCRLs after 8297955

[seanjmullan]

Please review this fix for a regression in the LDAP CertStore implementation where a null CRL issuerName in an X509CRLSelector should be treated as a CertStoreException instead of a NullPointerException.

A new test has been added but requires internal infrastructure so will only be in the closed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312126: NullPointerException in CertStore.getCRLs after 8297955 (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15745/head:pull/15745
$ git checkout pull/15745

Update a local copy of the PR:
$ git checkout pull/15745
$ git pull https://git.openjdk.org/jdk.git pull/15745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15745

View PR using the GUI difftool:
$ git pr show -t 15745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15745.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@seanjmullan The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[seanjmullan]

/label remove core-libs

[openjdk]

@seanjmullan
The core-libs label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (529cb4d4)

[openjdk]

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312126: NullPointerException in CertStore.getCRLs after 8297955

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 700 new commits pushed to the master branch:

• 4415261: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
• b2e9106: 8313452: Improve Classfile API attributes handling safety
• 2a6fb9c: 8316147: Remove serviceability/sa/TestJhsdbJstackMixed.java from -Xcomp problem list
• ca747f0: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing
• 6d47fc6: 8313258: RuntimeInvisibleTypeAnnotationsAttribute.annotations() API Index out of Bound error
• c7d306c: 8315541: Classfile API TypeAnnotation.TargetInfo factory methods accept null labels
• c11f835: 8315824: Open source several Swing Text/HTML related tests
• 5cea53d: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles
• eb1f67b: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
• a57b9da: 8316242: Opensource SwingGraphics manual test
• ... and 690 more: https://git.openjdk.org/jdk/compare/3fb9d117e353af6f007e701a8cd635763bd3cc28...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[seanjmullan]

/integrate

[openjdk]

Going to push as commit 3c743cf.
Since your change was applied there have been 717 commits pushed to the master branch:

• bd26813: 8316295: Serial: Remove empty Generation::promotion_failure_occurred
• 42dc6b5: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
• 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
• 89cb290: 8312165: Fix typos in java.desktop Swing
• 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
• 86dde5e: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
• 4f864fa: 8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations
• 4070829: 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV
• d575968: 8316178: Better diagnostic header for CodeBlobs
• bfbc41c: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• ... and 707 more: https://git.openjdk.org/jdk/compare/3fb9d117e353af6f007e701a8cd635763bd3cc28...master

Your commit was automatically rebased without conflicts.

[openjdk]

@seanjmullan Pushed as commit 3c743cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.