Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315804: Open source several Swing JTabbedPane JTextArea JTextField tests #15747

Closed

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Sep 14, 2023

These are the tests being converted:

javax/swing/JTabbedPane/4703690/bug4703690.java
javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java
javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java
javax/swing/JTextArea/4849868/bug4849868.java
javax/swing/JTextField/4244613/bug4244613.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315804: Open source several Swing JTabbedPane JTextArea JTextField tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15747/head:pull/15747
$ git checkout pull/15747

Update a local copy of the PR:
$ git checkout pull/15747
$ git pull https://git.openjdk.org/jdk.git pull/15747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15747

View PR using the GUI difftool:
$ git pr show -t 15747

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15747.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2023

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 14, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2023

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor nits

test/jdk/javax/swing/JTabbedPane/ReplaceCompTab.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTabbedPane/ReplaceCompTab.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTabbedPane/bug4703690.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTabbedPane/GetComponentAtTest.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTabbedPane/ReplaceCompTab.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTabbedPane/bug4703690.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTabbedPane/bug4703690.java Outdated Show resolved Hide resolved
robot = new Robot();
robot.setAutoDelay(50);
robot.delay(1000);
two.requestFocus();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may need to be called on EDT too.

Does it make sense to wait till the button receives focus?
I assume the following actions depend on this to happen.

Comment on lines 141 to 143
} catch (Exception t) {
throw new RuntimeException("Test failed", t);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This catch is redundant — declare the method to throw Exception and let them propagate to main which, in its turn, throws Exception.

test/jdk/javax/swing/JTextArea/bug4849868.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTextArea/bug4849868.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTextArea/bug4849868.java Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315804: Open source several Swing JTabbedPane JTextArea JTextField tests

Reviewed-by: honkar, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 181 new commits pushed to the master branch:

  • 373e37b: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set
  • 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model
  • dcea9bf: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 1b104b6: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • 4421951: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • f09b7af: 8311220: Optimization for StringLatin UpperLower
  • 2e2d49c: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • bf9d1e2: 8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX
  • 21c2dac: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
  • ecce2af: 8316357: Serial: Remove unused GenCollectedHeap::space_containing
  • ... and 171 more: https://git.openjdk.org/jdk/compare/969fcdb0de962b6eda7b362af010cb138e45afcf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2023
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

Going to push as commit 24c3d86.
Since your change was applied there have been 181 commits pushed to the master branch:

  • 373e37b: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set
  • 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model
  • dcea9bf: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 1b104b6: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • 4421951: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • f09b7af: 8311220: Optimization for StringLatin UpperLower
  • 2e2d49c: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • bf9d1e2: 8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX
  • 21c2dac: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
  • ecce2af: 8316357: Serial: Remove unused GenCollectedHeap::space_containing
  • ... and 171 more: https://git.openjdk.org/jdk/compare/969fcdb0de962b6eda7b362af010cb138e45afcf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 18, 2023
@openjdk openjdk bot closed this Sep 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@DamonGuy Pushed as commit 24c3d86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonGuy DamonGuy mentioned this pull request Oct 2, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants