Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315965: Open source various AWT applet tests #15754

Closed
wants to merge 3 commits into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Sep 14, 2023

Open sourcing few applet tests:

java/awt/ScrollPane/ScrollPaneTest.java
java/awt/TextArea/Length.java
java/awt/Window/WindowOwner.java
java/awt/font/Rotate/RotateTest3.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315965: Open source various AWT applet tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15754/head:pull/15754
$ git checkout pull/15754

Update a local copy of the PR:
$ git checkout pull/15754
$ git pull https://git.openjdk.org/jdk.git pull/15754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15754

View PR using the GUI difftool:
$ git pr show -t 15754

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15754.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 14, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2023

Webrevs

/*
* @test
* @bug 4120876
* @key headful
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not displaying anything, can the test be made headless?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, TextArea a heavyweight component and cannot be created in headless environment.

https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/TextComponent.java#L150

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/jdk/java/awt/font/Rotate/RotateTest3.java Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315965: Open source various AWT applet tests

Reviewed-by: honkar, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 105 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2023
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

Going to push as commit 3b397c8.
Since your change was applied there have been 109 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 21, 2023
@openjdk openjdk bot closed this Sep 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@azvegint Pushed as commit 3b397c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants