Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind #15757

Closed
wants to merge 9 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Sep 14, 2023

Add a finally block to delete the created files. Convert the test to JUnit 5.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15757/head:pull/15757
$ git checkout pull/15757

Update a local copy of the PR:
$ git checkout pull/15757
$ git pull https://git.openjdk.org/jdk.git pull/15757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15757

View PR using the GUI difftool:
$ git pr show -t 15757

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15757.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 14, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2023

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a small test, perhaps it would be worthwhile to convert to Junit as part of your cleanup

@bplb
Copy link
Member Author

bplb commented Sep 14, 2023

Given this is a small test, perhaps it would be worthwhile to convert to Junit as part of your cleanup

It was not completely obvious at first how to do this, but after some investigation, I think it is feasible.

@bplb
Copy link
Member Author

bplb commented Sep 15, 2023

[...] perhaps it would be worthwhile to convert to Junit

Please see dad75c5.

test/jdk/java/io/File/TempDirDoesNotExist.java Outdated Show resolved Hide resolved
test/jdk/java/io/File/TempDirDoesNotExist.java Outdated Show resolved Hide resolved
test/jdk/java/io/File/TempDirDoesNotExist.java Outdated Show resolved Hide resolved
test/jdk/java/io/File/TempDirDoesNotExist.java Outdated Show resolved Hide resolved
Copy link
Member

@djelinski djelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're using junit, we can start using assertions

test/jdk/java/io/File/TempDirDoesNotExist.java Outdated Show resolved Hide resolved
test/jdk/java/io/File/TempDirDoesNotExist.java Outdated Show resolved Hide resolved
test/jdk/java/io/File/TempDirDoesNotExist.java Outdated Show resolved Hide resolved
Copy link
Member

@djelinski djelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind

Reviewed-by: lancea, djelinski, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

  • c90d631: 8315750: Update subtype check profile collection on PPC following 8308869
  • 00f585b: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
  • bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
  • 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
  • a1e0346: 8316698: build failure caused by JDK-8316456
  • ... and 144 more: https://git.openjdk.org/jdk/compare/3b0a6d2a6842962218b8cebcd9c0672cb4ee6720...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2023
@bplb
Copy link
Member Author

bplb commented Sep 21, 2023

LGTM. Thanks!

Thanks (to everyone) for the constructive comments!

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
It may be useful to update the PR description and Issue description to include the refactoring of the test to Junit.

@bplb
Copy link
Member Author

bplb commented Sep 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit 373cdf2.
Since your change was applied there have been 157 commits pushed to the master branch:

  • f7578e8: 8316540: StoreReproducibilityTest fails on some locales
  • b66ded9: 8316688: Widen allowable error bound of Math.hypot
  • 6c61bc1: 8316514: Better diagnostic header for VtableStub
  • c90d631: 8315750: Update subtype check profile collection on PPC following 8308869
  • 00f585b: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
  • bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
  • 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • ... and 147 more: https://git.openjdk.org/jdk/compare/3b0a6d2a6842962218b8cebcd9c0672cb4ee6720...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@bplb Pushed as commit 373cdf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the TempDirDoesNotExist-8315960 branch September 22, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants