8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind

[bplb]

Add a finally block to delete the created files. Convert the test to JUnit 5.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind (Bug - P4)

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)
• Daniel Jeliński (@djelinski - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15757/head:pull/15757
$ git checkout pull/15757

Update a local copy of the PR:
$ git checkout pull/15757
$ git pull https://git.openjdk.org/jdk.git pull/15757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15757

View PR using the GUI difftool:
$ git pr show -t 15757

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15757.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 08: Full - Incremental (cc4a3369)
• 07: Full - Incremental (b3ac8c7b)
• 06: Full - Incremental (511c511f)
• 05: Full - Incremental (50411b85)
• 04: Full - Incremental (cab8fa50)
• 03: Full - Incremental (f940caed)
• 02: Full - Incremental (2d444213)
• 01: Full - Incremental (dad75c58)
• 00: Full (cc4d9f3f)

[LanceAndersen]

Given this is a small test, perhaps it would be worthwhile to convert to Junit as part of your cleanup

[bplb]

Given this is a small test, perhaps it would be worthwhile to convert to Junit as part of your cleanup

It was not completely obvious at first how to do this, but after some investigation, I think it is feasible.

[bplb]

[...] perhaps it would be worthwhile to convert to Junit

Please see dad75c5.

[djelinski]

Now that we're using junit, we can start using assertions

[djelinski]

LGTM. Thanks!

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind

Reviewed-by: lancea, djelinski, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

• c90d631: 8315750: Update subtype check profile collection on PPC following 8308869
• 00f585b: 8316206: Test StretchedFontTest.java fails for Baekmuk font
• c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
• bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
• 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
• 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
• 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
• fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
• 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
• a1e0346: 8316698: build failure caused by JDK-8316456
• ... and 144 more: https://git.openjdk.org/jdk/compare/3b0a6d2a6842962218b8cebcd9c0672cb4ee6720...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

LGTM. Thanks!

Thanks (to everyone) for the constructive comments!

[RogerRiggs]

Looking good.
It may be useful to update the PR description and Issue description to include the refactoring of the test to Junit.

[bplb]

/integrate

[openjdk]

Going to push as commit 373cdf2.
Since your change was applied there have been 157 commits pushed to the master branch:

• f7578e8: 8316540: StoreReproducibilityTest fails on some locales
• b66ded9: 8316688: Widen allowable error bound of Math.hypot
• 6c61bc1: 8316514: Better diagnostic header for VtableStub
• c90d631: 8315750: Update subtype check profile collection on PPC following 8308869
• 00f585b: 8316206: Test StretchedFontTest.java fails for Baekmuk font
• c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
• bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
• 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
• 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
• 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
• ... and 147 more: https://git.openjdk.org/jdk/compare/3b0a6d2a6842962218b8cebcd9c0672cb4ee6720...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 373cdf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.