Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again #15758

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Sep 15, 2023

java/awt/Mouse/EnterExitEvents/DragWindowTest.java was de-problemlisted wrongly under https://bugs.openjdk.org/browse/JDK-8315990.
This is creating lot of noise in our CI. Need to problemlist this test again.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15758/head:pull/15758
$ git checkout pull/15758

Update a local copy of the PR:
$ git checkout pull/15758
$ git pull https://git.openjdk.org/jdk.git pull/15758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15758

View PR using the GUI difftool:
$ git pr show -t 15758

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15758.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@jayathirthrao To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jayathirthrao
Copy link
Member Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@jayathirthrao
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

Thanks.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2023
@jayathirthrao
Copy link
Member Author

Thanks @dholmes-ora

@jayathirthrao
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

Going to push as commit 783e44d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2023
@openjdk openjdk bot closed this Sep 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@jayathirthrao Pushed as commit 783e44d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants