Skip to content

JDK-8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22#15759

Closed
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8316341
Closed

JDK-8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22#15759
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8316341

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 15, 2023

Currently sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22, it does not find the NSS libs because the new file system locations are not handled, unlike on Linux x86_64 .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15759/head:pull/15759
$ git checkout pull/15759

Update a local copy of the PR:
$ git checkout pull/15759
$ git pull https://git.openjdk.org/jdk.git pull/15759/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15759

View PR using the GUI difftool:
$ git pr show -t 15759

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15759.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Sep 15, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for tracking down and fixing.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22

Reviewed-by: lucy, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 149acd1: 8316207: Fix typos in java.io.StreamTokenizer
  • dc5ca1d: 8316031: SSLFlowDelegate should not log from synchronized block
  • 8dfde28: 8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java
  • 3c743cf: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • bd26813: 8316295: Serial: Remove empty Generation::promotion_failure_occurred
  • 42dc6b5: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved
  • 31c4e03: 8314551: More generic way to handshake GC threads with monitor deflation
  • 89cb290: 8312165: Fix typos in java.desktop Swing
  • 25f32f3: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}
  • 86dde5e: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
  • ... and 1 more: https://git.openjdk.org/jdk/compare/4070829ae589678578a93b2886e02e04cf0a1b01...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2023
@MBaesken
Copy link
Member Author

Hi Christoph and Lutz, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

Going to push as commit aa0ebee.
Since your change was applied there have been 18 commits pushed to the master branch:

  • ca3fe7b: 8315932: runtime/InvocationTests spend a lot of time on dependency verification
  • f440329: 8316391: (zipfs) ZipFileSystem.readFullyAt does not tolerate short reads
  • 4b8f5d0: 8316273: JDK-8315818 broke JVMCIPrintProperties on libgraal
  • e624198: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • c92bdb0: 8316187: Modernize examples in StringTokenizer and {Date,Number}Format
  • 8f46abc: 8315889: Open source several Swing HTMLDocument related tests
  • 0050447: 8316148: Remove sun/tools/jhsdb/JStackStressTest.java from problem list
  • 149acd1: 8316207: Fix typos in java.io.StreamTokenizer
  • dc5ca1d: 8316031: SSLFlowDelegate should not log from synchronized block
  • 8dfde28: 8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java
  • ... and 8 more: https://git.openjdk.org/jdk/compare/4070829ae589678578a93b2886e02e04cf0a1b01...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 18, 2023
@openjdk openjdk bot closed this Sep 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@MBaesken Pushed as commit aa0ebee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants