Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags #15771

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Sep 15, 2023

The test is updated to start the target VM with tested flags in addition to heap size.
Tested with tier1, and iter5/6 rt/svc with CI flags.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15771/head:pull/15771
$ git checkout pull/15771

Update a local copy of the PR:
$ git checkout pull/15771
$ git pull https://git.openjdk.org/jdk.git pull/15771/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15771

View PR using the GUI difftool:
$ git pr show -t 15771

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15771.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 15, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2023
@lmesnik
Copy link
Member Author

lmesnik commented Sep 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

Going to push as commit e0f8d16.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 7b1e2bf: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
  • da57d2a: 8308592: Framework for CA interoperability testing
  • a6d120d: 8316513: Serial: Remove unused invalidate_remembered_set
  • 607bd4e: 8316294: AIX: Build fopen system call fails on file _BUILD_LIBJDWP_objectfilenames.txt
  • f25c920: 8314774: Optimize URLEncoder
  • 7c5f2a2: 8315669: Open source several Swing PopupMenu related tests
  • cf74b8c: 8316337: (bf) Concurrency issue in DirectByteBuffer.Deallocator
  • 4461eeb: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked
  • 670b456: 8315038: Capstone disassembler stops when it sees a bad instruction
  • fab372d: 8316428: G1: Nmethod count statistics only count last code root set iterated
  • ... and 27 more: https://git.openjdk.org/jdk/compare/8f46abc938ffe338e25d5fdbdcfa0aaa12edfa58...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2023
@openjdk openjdk bot closed this Sep 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@lmesnik Pushed as commit e0f8d16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants