Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX #15777

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 17, 2023

Test java/net/MulticastSocket/Promiscuous.java shows the symptoms of JDK-8308807 as well and was forgotten to be excluded.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15777/head:pull/15777
$ git checkout pull/15777

Update a local copy of the PR:
$ git checkout pull/15777
$ git pull https://git.openjdk.org/jdk.git pull/15777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15777

View PR using the GUI difftool:
$ git pr show -t 15777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15777.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 17, 2023
@openjdk
Copy link

openjdk bot commented Sep 17, 2023

@RealCLanger To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@RealCLanger
Copy link
Contributor Author

/label net

@openjdk openjdk bot added the net net-dev@openjdk.org label Sep 17, 2023
@openjdk
Copy link

openjdk bot commented Sep 17, 2023

@RealCLanger
The net label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 17, 2023

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, just surprising that java/nio/channels/DatagramChannel/Promiscuous.java passes but MulticastSocket/Promiscuous.java fails.

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • aa0ebee: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22
  • ca3fe7b: 8315932: runtime/InvocationTests spend a lot of time on dependency verification

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2023
@RealCLanger
Copy link
Contributor Author

RealCLanger commented Sep 18, 2023

Looks okay, just surprising that java/nio/channels/DatagramChannel/Promiscuous.java passes but MulticastSocket/Promiscuous.java fails.

Without a deeper look, it seems to me that in java/nio/channels/DatagramChannel/Promiscuous.java, AIX is not part of the platforms where joining an IPv4 Multicast group from an an IPv6 channel is attempted, as per this coding. I guess this would also be the type of fixing we'd have to apply to each single test.

@AlanBateman
Copy link
Contributor

Without a deeper look, it seems to me that in java/nio/channels/DatagramChannel/Promiscuous.java, AIX is not part of the platforms where joining an IPv4 Multicast group from an an IPv6 channel is attempted, as per this coding. I guess this would also be the type of fixing we'd have to apply to each single test.

Thanks, that explains. There's been a flurry of issues related to AIX + multicasting. I think the main issue is that nobody has pointed to something authoritative that says whether AIX allows a dual socket join an IPv4 multicast group or not. It sounds like it doesn't allow it, in which case I assume the issue has been there since JDK 1.4 or whenever the AIX port added support for IPv6.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

Going to push as commit bf9d1e2.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 21c2dac: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
  • ecce2af: 8316357: Serial: Remove unused GenCollectedHeap::space_containing
  • 3828dc9: 8314236: Overflow in Collections.rotate
  • 1203e11: 8294969: Convert jdk.jdeps javap to use the Classfile API
  • fbc766e: 8315988: Parallel: Make TestAggressiveHeap use createTestJvm
  • aa0ebee: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22
  • ca3fe7b: 8315932: runtime/InvocationTests spend a lot of time on dependency verification

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 18, 2023
@openjdk openjdk bot closed this Sep 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@RealCLanger Pushed as commit bf9d1e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the JDK-8316399 branch September 18, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
2 participants