Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259265: Refactor UncaughtExceptions shell test as java test. #1578

Conversation

@frkator
Copy link
Member

@frkator frkator commented Dec 2, 2020

Refactor test/jdk/java/lang/Thread/UncaughtExceptions.sh as java test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259265: Refactor UncaughtExceptions shell test as java test.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1578/head:pull/1578
$ git checkout pull/1578

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 2, 2020

👋 Welcome back isipka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@frkator The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Dec 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 2, 2020

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Please rename the class Seppuku to a more generic name for a process that exits as the result of an uncaught exception. Perhaps a simple "UncaughtExit".

Copy link
Member Author

@frkator frkator left a comment

Please rename the class Seppuku to a more generic name for a process that exits as the result of an uncaught exception. Perhaps a simple "UncaughtExit".

How does UncaughtExitSimulator sound?

test/jdk/java/lang/Thread/UncaughtExceptionsTest.java Outdated Show resolved Hide resolved
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 4, 2021

@frkator This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Sorry I missed the update; looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@frkator This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259265: Refactor UncaughtExceptions shell test as java test.

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 376 new commits pushed to the master branch:

  • 4d3d599: 8259223: Simplify boolean expression in the SunJSSE provider
  • 1b60acd: 8259252: Shenandoah: Shenandoah build failed on AArch64 after JDK-8258459
  • 7ddc2b5: 8258852: Arrays.asList() for single item could be replaced with List.of()
  • 85bac8c: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields
  • d5aa49d: 8259236: C2 compilation fails with assert(is_power_of_2(value)) failed: value must be a power of 2: 8000000000000000
  • 82bdbfd: 8258857: Zero: non-PCH release build fails after JDK-8258074
  • f4122d6: 8258896: Remove the JVM ForceFloatExceptions option
  • fc3b45c: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
  • a6c0881: 8256321: Some "inactive" color profiles use the wrong profile class
  • 9f15164: 8259049: Uninitialized variable after JDK-8257513
  • ... and 366 more: https://git.openjdk.java.net/jdk/compare/692b273ec53f54a879a4bbaad6c2f5f1d5358a71...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 4, 2021
@frkator
Copy link
Member Author

@frkator frkator commented Jan 5, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@frkator
Your change (at version c94ef2c) is now ready to be sponsored by a Committer.

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jan 5, 2021

Please synchronize the PR with the bug, the bugid 8166026 has been resolved already.

@frkator frkator changed the title 8166026: Refactor java/lang shell tests to java 8259265: Refactor UncaughtExceptions shell test as java test. Jan 5, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 2, 2021

@frkator This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@iignatev
Copy link
Member

@iignatev iignatev commented Feb 3, 2021

/sponsor

@openjdk openjdk bot closed this Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@iignatev @frkator Since your change was applied there have been 835 commits pushed to the master branch:

  • 5324b5c: 8260998: Shenandoah: Restore reference processing statistics reporting
  • c8de943: 8260617: Merge ZipFile encoding check with the initial hash calculation
  • ae2c5f0: 8260581: IGV: enhance node search
  • 9037615: 8222850: jshell tool: Misleading cascade compiler error in switch expression with undefined vars
  • 91e6c75: 8260928: InitArrayShortSize constraint func should print a helpful error message
  • cb127a4: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
  • c008410: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
  • b9d4211: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX
  • 98a7692: 8076313: GraphicsEnvironment does not detect changes in count of monitors on Linux OS
  • a47befc: 8260878: com/sun/jdi/JdbOptions.java fails without jfr
  • ... and 825 more: https://git.openjdk.java.net/jdk/compare/692b273ec53f54a879a4bbaad6c2f5f1d5358a71...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0ef93fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@frkator frkator deleted the frkator:JDK-8166026-refactor-shell-to-java-uncaughtexceptions branch Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants