Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing #15783

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 18, 2023

We run sometimes into this error (especially on some virtualized windows machines) :

java.lang.RuntimeException: 'force inline by CompileCommand' missing from stdout/stderr
at jdk.test.lib.process.OutputAnalyzer.shouldContain(OutputAnalyzer.java:221)
at compiler.compilercontrol.TestConflictInlineCommands.main(TestConflictInlineCommands.java:63)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
at java.base/java.lang.Thread.run(Thread.java:1570)

Maybe we do not reach the "force inline" action of the JIT so the output is missing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15783/head:pull/15783
$ git checkout pull/15783

Update a local copy of the PR:
$ git checkout pull/15783
$ git pull https://git.openjdk.org/jdk.git pull/15783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15783

View PR using the GUI difftool:
$ git pr show -t 15783

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15783.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 18, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing

Reviewed-by: mdoerr, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • ec74194: 8316546: Backout JDK-8315932: runtime/InvocationTests spend a lot of time on dependency verification
  • 2568188: 8316547: Use JUnit.dir jtreg property with jpackage JUnit tests
  • 833a828: 8315876: Open source several Swing CSS related tests
  • 7ce5bd1: 8316468: os::write incorrectly handles partial write
  • d19e017: 8315951: Open source several Swing HTMLEditorKit related tests
  • 62c0a1b: 8315883: Open source several Swing JToolbar tests
  • 0c97246: 8311113: Remove invalid pointer cast and clean up setLabel() in awt_MenuItem.cpp
  • d2b2f67: 8315952: Open source several Swing JToolbar JTooltip JTree tests
  • 5f6cee8: 8316056: Open source several Swing JTree tests
  • b685ee0: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • ... and 29 more: https://git.openjdk.org/jdk/compare/3828dc913a3ea28d622b69bd07f26949128eb5f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2023
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MBaesken
Copy link
Member Author

Hi Christian and Martin, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

Going to push as commit e1870d3.
Since your change was applied there have been 39 commits pushed to the master branch:

  • ec74194: 8316546: Backout JDK-8315932: runtime/InvocationTests spend a lot of time on dependency verification
  • 2568188: 8316547: Use JUnit.dir jtreg property with jpackage JUnit tests
  • 833a828: 8315876: Open source several Swing CSS related tests
  • 7ce5bd1: 8316468: os::write incorrectly handles partial write
  • d19e017: 8315951: Open source several Swing HTMLEditorKit related tests
  • 62c0a1b: 8315883: Open source several Swing JToolbar tests
  • 0c97246: 8311113: Remove invalid pointer cast and clean up setLabel() in awt_MenuItem.cpp
  • d2b2f67: 8315952: Open source several Swing JToolbar JTooltip JTree tests
  • 5f6cee8: 8316056: Open source several Swing JTree tests
  • b685ee0: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • ... and 29 more: https://git.openjdk.org/jdk/compare/3828dc913a3ea28d622b69bd07f26949128eb5f7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2023
@openjdk openjdk bot closed this Sep 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@MBaesken Pushed as commit e1870d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants