Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8316420: Serial: Remove unused GenCollectedHeap::oop_iterate #15785

Closed
wants to merge 3 commits into from
Closed

8316420: Serial: Remove unused GenCollectedHeap::oop_iterate #15785

wants to merge 3 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Sep 18, 2023 •
edited by openjdk bot
Loading

Trivial removing dead code.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316420: Serial: Remove unused GenCollectedHeap::oop_iterate (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15785/head:pull/15785
$ git checkout pull/15785

Update a local copy of the PR:
$ git checkout pull/15785
$ git pull https://git.openjdk.org/jdk.git pull/15785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15785

View PR using the GUI difftool:
$ git pr show -t 15785

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15785.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8316420 8316420: Serial: Remove unused GenCollectedHeap::oop_iterate Sep 18, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 18, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2023 •
edited
Loading

Webrevs

stefank
stefank approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@stefank stefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Is this the last usage of Generation::oop_iterate, GenerationOopIterateClosure, and *Space::oop_iterate?

@openjdk
Copy link

openjdk bot commented Sep 18, 2023 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316420: Serial: Remove unused GenCollectedHeap::oop_iterate

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 138542d: 8316061: Open source several Swing RootPane and Slider related tests
  • f52e500: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • 3760a04: 8314021: HeapDump: Optimize segmented heap file merging phase
  • f226ceb: 8316440: LambdasInTwoArchives.java failed to find WhiteBox.class
  • 24c3d86: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests
  • 373e37b: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set
  • 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model
  • dcea9bf: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 1b104b6: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • 4421951: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • ... and 4 more: https://git.openjdk.org/jdk/compare/ecce2afc1a99bc0be53097ef89d2726201da04bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2023
@albertnetymk
Copy link
Member Author

Yes, it is. Removed as well.

stefank
stefank approved these changes Sep 18, 2023
View reviewed changes
src/hotspot/share/gc/shared/space.hpp
@@ -443,8 +438,6 @@ class ContiguousSpace: public Space {
HeapWord* allocate(size_t word_size) override;
HeapWord* par_allocate(size_t word_size) override;

// Iteration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment could be left.

tschatzl
tschatzl approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

Going to push as commit 86115c2.
Since your change was applied there have been 15 commits pushed to the master branch:

  • d038571: 8030815: Code roots are not accounted for in region prediction
  • 138542d: 8316061: Open source several Swing RootPane and Slider related tests
  • f52e500: 8316104: Open source several Swing SplitPane and RadioButton related tests
  • 3760a04: 8314021: HeapDump: Optimize segmented heap file merging phase
  • f226ceb: 8316440: LambdasInTwoArchives.java failed to find WhiteBox.class
  • 24c3d86: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests
  • 373e37b: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set
  • 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model
  • dcea9bf: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 1b104b6: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • ... and 5 more: https://git.openjdk.org/jdk/compare/ecce2afc1a99bc0be53097ef89d2726201da04bb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2023
@openjdk openjdk bot closed this Sep 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@albertnetymk Pushed as commit 86115c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-remove-oop-iter branch September 19, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefank stefank stefank approved these changes

@tschatzl tschatzl tschatzl approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertnetymk @stefank @tschatzl