8316098: Revise signature of numa_get_leaf_groups

[albertnetymk]

Simple refactoring to better reflect NUMA node id is non-negative using unsigned type.

More cleanup can possibly be done to avoid the use of checked_cast in os_windows.cpp, but since the NUMA code in Windows is unreachable (JDK-8244065), I went to for the smallest diff there in order to avoid adding more untested code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316098: Revise signature of numa_get_leaf_groups (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15786/head:pull/15786
$ git checkout pull/15786

Update a local copy of the PR:
$ git checkout pull/15786
$ git pull https://git.openjdk.org/jdk.git pull/15786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15786

View PR using the GUI difftool:
$ git pr show -t 15786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15786.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (efa5538f)

[tschatzl]

Lgtm. Please file an RFE for fixing

"More cleanup can possibly be done to avoid the use of checked_cast in os_windows.cpp, but since the NUMA code in Windows is unreachable (JDK-8244065), I went to for the smallest diff there in order to avoid adding more untested code."

and link it to JDK-8244065. Thanks.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316098: Revise signature of numa_get_leaf_groups

Reviewed-by: tschatzl, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 126 new commits pushed to the master branch:

• 52983ed: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
• 9e6cb62: 8316851: Add @sealedGraph to Executable
• 3fe6e0f: 8308479: [s390x] Implement alternative fast-locking scheme
• e2e8e8e: 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing
• 0dce4c1: 8313220: Remove Windows specific workaround in LCMS.c for _snprintf
• e5f05b5: 8312191: ColorConvertOp.filter for the default destination is too slow
• be9cc73: 8315871: Opensource five more Swing regression tests
• b65f4f7: 8313403: Remove unused 'mask' field from JFormattedTextField
• e3201d1: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• 9291b46: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system
• ... and 116 more: https://git.openjdk.org/jdk/compare/ecce2afc1a99bc0be53097ef89d2726201da04bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Filed https://bugs.openjdk.org/browse/JDK-8316886

[coleenp]

Looks good to me.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit e510dee.
Since your change was applied there have been 127 commits pushed to the master branch:

• 1513e79: 8316940: Serial: Remove unused declarations in genCollectedHeap
• 52983ed: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
• 9e6cb62: 8316851: Add @sealedGraph to Executable
• 3fe6e0f: 8308479: [s390x] Implement alternative fast-locking scheme
• e2e8e8e: 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing
• 0dce4c1: 8313220: Remove Windows specific workaround in LCMS.c for _snprintf
• e5f05b5: 8312191: ColorConvertOp.filter for the default destination is too slow
• be9cc73: 8315871: Opensource five more Swing regression tests
• b65f4f7: 8313403: Remove unused 'mask' field from JFormattedTextField
• e3201d1: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• ... and 117 more: https://git.openjdk.org/jdk/compare/ecce2afc1a99bc0be53097ef89d2726201da04bb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit e510dee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.