-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316389: Open source few AWT applet tests #15787
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. One minor asterisk alignment found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we add @Override
annotations?
.columns(45) | ||
.build(); | ||
|
||
SwingUtilities.invokeAndWait(() -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, yet JFrame
is hidden away inside PassFailJFrame
.
The test itself uses AWT components, therefore it's reasonable not to use SwingUtilities
. Functionally, there's no change, so I'm nitpicking.
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 119 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 65227a3.
Your commit was automatically rebased without conflicts. |
Open sourcing few tests:
java/awt/Frame/FrameRepackTest.java
java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
java/awt/Frame/WindowMoveTest.java
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15787/head:pull/15787
$ git checkout pull/15787
Update a local copy of the PR:
$ git checkout pull/15787
$ git pull https://git.openjdk.org/jdk.git pull/15787/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15787
View PR using the GUI difftool:
$ git pr show -t 15787
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15787.diff
Webrev
Link to Webrev Comment