Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316389: Open source few AWT applet tests #15787

Closed
wants to merge 8 commits into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Sep 18, 2023

Open sourcing few tests:

java/awt/Frame/FrameRepackTest.java
java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
java/awt/Frame/WindowMoveTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316389: Open source few AWT applet tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15787/head:pull/15787
$ git checkout pull/15787

Update a local copy of the PR:
$ git checkout pull/15787
$ git pull https://git.openjdk.org/jdk.git pull/15787/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15787

View PR using the GUI difftool:
$ git pr show -t 15787

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15787.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 18, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2023

Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. One minor asterisk alignment found

test/jdk/java/awt/Frame/FrameRepackTest.java Outdated Show resolved Hide resolved
Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we add @Override annotations?

test/jdk/java/awt/Frame/FrameRepackTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/FrameRepackTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/FrameRepackTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/FrameRepackTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/FrameRepackTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/WindowMoveTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/WindowMoveTest.java Outdated Show resolved Hide resolved
.columns(45)
.build();

SwingUtilities.invokeAndWait(() -> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, yet JFrame is hidden away inside PassFailJFrame.

The test itself uses AWT components, therefore it's reasonable not to use SwingUtilities. Functionally, there's no change, so I'm nitpicking.

test/jdk/java/awt/Frame/WindowMoveTest.java Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316389: Open source few AWT applet tests

Reviewed-by: dnguyen, abhiscxk, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 119 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2023
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

Going to push as commit 65227a3.
Since your change was applied there have been 134 commits pushed to the master branch:

  • 788e6e1: 8316218: Open some swing tests 5
  • ee9776f: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper
  • 36ac839: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable
  • efb7e85: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 4e1e579: 8315920: C2: "control input must dominate current control" assert failure
  • 1f7dfda: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
  • 20ff603: 8316735: Print LockStack in hs_err files
  • e510dee: 8316098: Revise signature of numa_get_leaf_groups
  • 1513e79: 8316940: Serial: Remove unused declarations in genCollectedHeap
  • 52983ed: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
  • ... and 124 more: https://git.openjdk.org/jdk/compare/21c2dac15957e6d71e8f32a55f3825671da097a9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2023
@openjdk openjdk bot closed this Sep 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@azvegint Pushed as commit 65227a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
6 participants