Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253098: Archived full module graph should be disabled if CDS heap cannot be mapped #158

Closed

Conversation

@iklam
Copy link
Member

@iklam iklam commented Sep 14, 2020

Please review this simple fix -- MetaspaceShared::use_full_module_graph() depends on the CDS heap. It should be disabled if the CDS heap cannot be mapped.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253098: Disable archived module graph if CDS heap cannot be mapped ⚠️ Title mismatch between PR and JBS.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/158/head:pull/158
$ git checkout pull/158

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@iklam The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@iklam iklam marked this pull request as ready for review Sep 14, 2020
@openjdk openjdk bot added the rfr label Sep 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2020

Webrevs

Loading

Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@iklam This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253098: Archived full module graph should be disabled if CDS heap cannot be mapped

Reviewed-by: ccheung, dholmes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ac9d1b08ee4a9f54cd75a4115adffcc4c0fb105d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 14, 2020
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good.

Loading

@iklam
Copy link
Member Author

@iklam iklam commented Sep 15, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@iklam Pushed as commit 70cc7fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants