Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316306: Open source and convert manual Swing test #15806

Closed

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Sep 19, 2023

This is to convert and open source test: javax/swing/JToolBar/4203039/bug4203039.java

This manual test now uses PassFailJFrame to handle the display for the instructions text as well as the pass/fail buttons.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316306: Open source and convert manual Swing test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15806/head:pull/15806
$ git checkout pull/15806

Update a local copy of the PR:
$ git checkout pull/15806
$ git pull https://git.openjdk.org/jdk.git pull/15806/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15806

View PR using the GUI difftool:
$ git pr show -t 15806

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15806.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2023

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 19, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2023

Webrevs

* @test
* @bug 4203039
* @summary JToolBar needs a way to limit docking to a particular orientation
* @library /java/awt/regtesthelpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path to PassFailJFrame looks good.

test/jdk/javax/swing/JToolBar/bug4203039.java Outdated Show resolved Hide resolved
Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316306: Open source and convert manual Swing test

Reviewed-by: honkar, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 221 new commits pushed to the master branch:

  • 3301fb1: 8315869: UseHeavyMonitors not used
  • 54028e7: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829
  • 7c991cc: 8296246: Update Unicode Data Files to Version 15.1.0
  • a021dbc: 8316149: Open source several Swing JTree JViewport KeyboardManager tests
  • 455cfae: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
  • 9e00949: 8316427: Duplicated code for {obj,type}ArrayKlass::array_klass
  • c43ebd3: 8315981: Opensource five more random Swing tests
  • e30e356: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • 242eeae: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • b275bdd: 8308995: Update Network IO JFR events to be static mirror events
  • ... and 211 more: https://git.openjdk.org/jdk/compare/969fcdb0de962b6eda7b362af010cb138e45afcf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2023
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

Going to push as commit d3e8218.
Since your change was applied there have been 250 commits pushed to the master branch:

  • 4e57177: 8316383: NullPointerException in AbstractSAXParser after JDK-8306632
  • 3b397c8: 8315965: Open source various AWT applet tests
  • c698b45: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2
  • 015f6f5: 8315771: [JVMCI] Resolution of bootstrap methods with int[] static arguments
  • 83b01cf: 8311922: [macOS] right-Option key fails to generate release event
  • 542b300: 8315954: getArgumentValues002.java fails on Graal
  • 0637900: 8316433: net.dll should delay load winhttp.dll
  • 90bcdbd: 8316581: Improve performance of Symbol::print_value_on()
  • 8350268: 8316453: [JVMCI] Using Xcomp on jargraal must eagerly initialize JVMCI
  • 3809d69: 8316240: Open source several add/remove MenuBar manual tests
  • ... and 240 more: https://git.openjdk.org/jdk/compare/969fcdb0de962b6eda7b362af010cb138e45afcf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 21, 2023
@openjdk openjdk bot closed this Sep 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@DamonGuy Pushed as commit d3e8218.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants