8257631: C2: Assertion failure in ArrayCopyNode::get_count() during late inlining

[iwanowww]

The problematic assert in ArrayCopyNode::get_count() is specifically targeted at parsing phase, but it doesn't filter out late inlining which exposes the problematic IR shape the assert guards against.

Testing:

• hs-tier1-6 w/ -XX:+AlwaysIncrementalInline

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257631: C2: Assertion failure in ArrayCopyNode::get_count() during late inlining

Reviewers

• Nils Eliasson (@neliasso - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1581/head:pull/1581
$ git checkout pull/1581

[bridgekeeper]

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iwanowww The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4690e3a)

[neliasso]

Looks good.

[openjdk]

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257631: C2: Assertion failure in ArrayCopyNode::get_count() during late inlining

Reviewed-by: neliasso, kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• d08c612: 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton
• 49f9e57: 8257734: Extraneous output in HmacSHA3_512 constructor
• f83fd4a: 8257438: Avoid adding duplicate values into extendedKeyCodesSet
• 37c7835: 8257673: Build fails without shenandoahgc after JDK-8257563
• f0b1194: 8235784: java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java fails due to timeout with fastdebug bits
• 36209b7: 8257547: Handle multiple prereqs on the same line in deps files
• c5b32b3: 8256808: com/sun/jdi/CatchAllTest.java failed with "NullPointerException: Cannot invoke "lib.jdb.Jdb.log(String)" because "this.jdb" is null"
• 8526947: 6508941: java.awt.Desktop.open causes VM to crash with video files sporadically
• 7c7facc: 8257701: Shenandoah: objArrayKlass metadata is not marked with chunked arrays
• 2b73f99: 8228615: Optional.empty doc should suggest using isEmpty
• ... and 47 more: https://git.openjdk.java.net/jdk/compare/927504e8270b4ea44c10d7faf0959b107281ddfe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good.

[iwanowww]

Thanks for the reviews, Nils, Vladimir, and Tobias.

[iwanowww]

/integrate

[openjdk]

@iwanowww Since your change was applied there have been 60 commits pushed to the master branch:

• 417e7e6: 8257632: C2: Late inlining attempt on a call with a dead memory crashes
• 6845fee: 8257625: C2: Harden input checks in vector intrinsics
• 4390f2c: 8257630: C2: ReplacedNodes doesn't handle non-CFG multi nodes
• d08c612: 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton
• 49f9e57: 8257734: Extraneous output in HmacSHA3_512 constructor
• f83fd4a: 8257438: Avoid adding duplicate values into extendedKeyCodesSet
• 37c7835: 8257673: Build fails without shenandoahgc after JDK-8257563
• f0b1194: 8235784: java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java fails due to timeout with fastdebug bits
• 36209b7: 8257547: Handle multiple prereqs on the same line in deps files
• c5b32b3: 8256808: com/sun/jdi/CatchAllTest.java failed with "NullPointerException: Cannot invoke "lib.jdb.Jdb.log(String)" because "this.jdb" is null"
• ... and 50 more: https://git.openjdk.java.net/jdk/compare/927504e8270b4ea44c10d7faf0959b107281ddfe...master

Your commit was automatically rebased without conflicts.

Pushed as commit f33808f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.