Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316206: Test StretchedFontTest.java fails for Baekmuk font #15818

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 19, 2023

Root cause

The Baekmuk Headline font maps \u6f22 (漢) to glyph id 16950 which has zero length.

The test fails if the right half of the image with the rendered glyph contains only pixels of background colour. In this case, the left half of the image is also blank. It's somewhat false positive because of the broken font.

Fix

Ignore fonts which don't render the glyph correctly. If the left half of the image contains pixels of the background colour only, it is expected that the right half also contains background-coloured pixels only.

The updated test does not fail with the Baekmuk Headline font. It still detects the original problem and fails on builds without the fix for JDK-8312555.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316206: Test StretchedFontTest.java fails for Baekmuk font (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15818/head:pull/15818
$ git checkout pull/15818

Update a local copy of the PR:
$ git checkout pull/15818
$ git pull https://git.openjdk.org/jdk.git pull/15818/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15818

View PR using the GUI difftool:
$ git pr show -t 15818

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15818.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 19, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2023

Webrevs

@prrace
Copy link
Contributor

prrace commented Sep 19, 2023

I was thinking of a more direct font-oriented verification like this
import java.awt.;
import java.awt.font.
;

public class GO {
public static void main(String args[]) {
Font font = new Font(Font.SANS_SERIF, Font.PLAIN, 20);
FontRenderContext frc = new FontRenderContext(null, false, false);
GlyphVector gv = font.createGlyphVector(frc, "o");
boolean empty = gv.getVisualBounds().isEmpty();
System.out.println("empty="+empty);
}
}

% java GO
empty=true

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316206: Test StretchedFontTest.java fails for Baekmuk font

Ignore broken fonts, i.e. the fonts for which
GlyphVector(TEXT).getVisualBounds().isEmpty() returns true

Reviewed-by: azvegint, prr, goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

  • c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
  • bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
  • 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
  • a1e0346: 8316698: build failure caused by JDK-8316456
  • c72f004: 8316456: StackWalker may skip Continuation::yield0 frame mistakenly
  • 041510d: 8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out
  • ... and 61 more: https://git.openjdk.org/jdk/compare/cf74b8c2a32f33019a13ce80b6667da502cc6722...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 19, 2023
Filter out broken fonts by GlyphVector.getVisualBounds().isEmpty()
@aivanov-jdk
Copy link
Member Author

I was thinking of a more direct font-oriented verification like this

import java.awt.*;
import java.awt.font.*;

public class GO {
    public static void main(String args[]) {
        Font font = new Font(Font.SANS_SERIF, Font.PLAIN, 20);
        FontRenderContext frc = new FontRenderContext(null, false, false);
        GlyphVector gv = font.createGlyphVector(frc, "o");
        boolean empty = gv.getVisualBounds().isEmpty();
        System.out.println("empty="+empty);
    }
}
% java GO
empty=true

@prrace Thank you! It's a much cleaner approach. I've updated the PR.

When I run the test on Linux with, I get the a diagnostic message:

~/work/jdk-dev$ ~/dev/tools/jdk20/bin/java test/jdk/java/awt/Font/FontScaling/StretchedFontTest.java
Broken font: Baekmuk Headline

@aivanov-jdk
Copy link
Member Author

/summary
Ignore broken fonts, i.e. the fonts for which
GlyphVector(TEXT).getVisualBounds().isEmpty() returns true

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@aivanov-jdk Setting summary to:

Ignore broken fonts, i.e. the fonts for which
GlyphVector(TEXT).getVisualBounds().isEmpty() returns true

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes with this patch on our machine. LGTM.

@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit 00f585b.
Since your change was applied there have been 71 commits pushed to the master branch:

  • c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
  • bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
  • 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
  • a1e0346: 8316698: build failure caused by JDK-8316456
  • c72f004: 8316456: StackWalker may skip Continuation::yield0 frame mistakenly
  • 041510d: 8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out
  • ... and 61 more: https://git.openjdk.org/jdk/compare/cf74b8c2a32f33019a13ce80b6667da502cc6722...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@aivanov-jdk Pushed as commit 00f585b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin
Copy link
Member

GoeLin commented Sep 27, 2023

Thanks for this timely fix!

@aivanov-jdk aivanov-jdk deleted the 8316206-Baekmuk-font-StretchedFontTest branch September 27, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants