Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8316383: NullPointerException in AbstractSAXParser after JDK-8306632 #15828

Closed
wants to merge 2 commits into from
Closed

8316383: NullPointerException in AbstractSAXParser after JDK-8306632 #15828

wants to merge 2 commits into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Sep 19, 2023 •
edited by openjdk bot
Loading

Fix a NPE. The DTD patch (JDK-8306632) moved initialization to factories, for example, for SAXParser, the SecurityManagers are created in the SAXParserFactory impl and passed on to instances of SAXParsers. The (deprecated) XMLReaderFactory however, instantiates SAXParsers directly, thus without initializing the SecurityManagers. This patch checks the condition and creates them if they have not already been constructed.

Test: XML tests passed.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316383: NullPointerException in AbstractSAXParser after JDK-8306632 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15828/head:pull/15828
$ git checkout pull/15828

Update a local copy of the PR:
$ git checkout pull/15828
$ git pull https://git.openjdk.org/jdk.git pull/15828/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15828

View PR using the GUI difftool:
$ git pr show -t 15828

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15828.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2023

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 19, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2023 •
edited
Loading

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 21, 2023 •
edited
Loading

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316383: NullPointerException in AbstractSAXParser after JDK-8306632

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

  • 3b397c8: 8315965: Open source various AWT applet tests
  • c698b45: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2
  • 015f6f5: 8315771: [JVMCI] Resolution of bootstrap methods with int[] static arguments
  • 83b01cf: 8311922: [macOS] right-Option key fails to generate release event
  • 542b300: 8315954: getArgumentValues002.java fails on Graal
  • 0637900: 8316433: net.dll should delay load winhttp.dll
  • 90bcdbd: 8316581: Improve performance of Symbol::print_value_on()
  • 8350268: 8316453: [JVMCI] Using Xcomp on jargraal must eagerly initialize JVMCI
  • 3809d69: 8316240: Open source several add/remove MenuBar manual tests
  • 38bf119: 8310228: Improve error reporting for uncaught native exceptions on Windows
  • ... and 55 more: https://git.openjdk.org/jdk/compare/3760a0448df7024f9b44fa2af11007de4dfcbbe2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2023
naotoj
naotoj approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/java.xml/share/classes/jdk/xml/internal/Utils.java Outdated
* The {@systemProperty jaxp.debug} property is supported by JAXP factories
* and used to print out information related to the configuration of factories
* and processors
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: indentation

@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

Going to push as commit 4e57177.
Since your change was applied there have been 65 commits pushed to the master branch:

  • 3b397c8: 8315965: Open source various AWT applet tests
  • c698b45: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2
  • 015f6f5: 8315771: [JVMCI] Resolution of bootstrap methods with int[] static arguments
  • 83b01cf: 8311922: [macOS] right-Option key fails to generate release event
  • 542b300: 8315954: getArgumentValues002.java fails on Graal
  • 0637900: 8316433: net.dll should delay load winhttp.dll
  • 90bcdbd: 8316581: Improve performance of Symbol::print_value_on()
  • 8350268: 8316453: [JVMCI] Using Xcomp on jargraal must eagerly initialize JVMCI
  • 3809d69: 8316240: Open source several add/remove MenuBar manual tests
  • 38bf119: 8310228: Improve error reporting for uncaught native exceptions on Windows
  • ... and 55 more: https://git.openjdk.org/jdk/compare/3760a0448df7024f9b44fa2af11007de4dfcbbe2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 21, 2023
@openjdk openjdk bot closed this Sep 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@JoeWang-Java Pushed as commit 4e57177.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8316383 branch October 3, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LanceAndersen LanceAndersen LanceAndersen approved these changes

@naotoj naotoj naotoj approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang-Java @naotoj @LanceAndersen