Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316540: StoreReproducibilityTest fails on some locales #15829

Closed

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Sep 19, 2023

Fixing a test case that fails in some time zones. Making sure the test is run in UTC zone will fix the issue. Confirmed the fix by manually setting machine's time zone to Europe/Dublin.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316540: StoreReproducibilityTest fails on some locales (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15829/head:pull/15829
$ git checkout pull/15829

Update a local copy of the PR:
$ git checkout pull/15829
$ git pull https://git.openjdk.org/jdk.git pull/15829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15829

View PR using the GUI difftool:
$ git pr show -t 15829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15829.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 19, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2023

Webrevs

@jaikiran
Copy link
Member

jaikiran commented Sep 20, 2023

Hello Naoto, the use of UTC looks good to me. Since the failing assertCurrentDate() method is only called in testEmptySysPropValue(), should we perhaps limit this usage of UTC timezone to only that test? The rest of test methods just verify that whatever value was passed to the java.properties.date system property was written out as a comment in the properties file and they don't assert any Date semantics.

@naotoj
Copy link
Member Author

naotoj commented Sep 20, 2023

Thanks, Jai.
Since assertCurrentDate() is apart from the actual JVM invoking test method testEmptySysPropValue(), I thought it would be safer to use UTC in all test cases so that if someone calls assertCurrentDate() in other test methods, the test wouldn't break. But you are right that they are not needed in other locations right now. I removed those locations and instead added some instructions in assertCurrentDate() for future proof.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316540: StoreReproducibilityTest fails on some locales

Reviewed-by: joehw, jlu, jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
  • a1e0346: 8316698: build failure caused by JDK-8316456
  • c72f004: 8316456: StackWalker may skip Continuation::yield0 frame mistakenly
  • 041510d: 8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out
  • ef49e6c: 8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful
  • 496264c: 8316435: sun.util.calendar.CalendarSystem subclassing should be restricted
  • 1100dbc: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
  • d3e8218: 8316306: Open source and convert manual Swing test
  • 4e57177: 8316383: NullPointerException in AbstractSAXParser after JDK-8306632
  • ... and 73 more: https://git.openjdk.org/jdk/compare/f09b7af6851c725b0fc4d63832b52e17c4d24836...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2023
Copy link
Member

@justin-curtis-lu justin-curtis-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Naoto for the update. This looks good to me.

@@ -137,7 +137,7 @@ private static void testWithSecMgrExplicitPermission() throws Exception {
final ProcessBuilder processBuilder = ProcessTools.createJavaProcessBuilder(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProcessTools.createJavaProcessBuilder came up in another PR because it doesn't prepend the VM and java opts. As all usages of PB are being updated in this test then it makes me wonder if it should be changed to use createTestJvm while you're there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was limiting the change to a single JVM invocation 😄
But yes, it is appropriate to replace the invocation. Replaced them all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yes, it is appropriate to replace the invocation. Replaced them all.

Thanks

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between createJavaProcessBuilder() and createTestJvm() appears to be that additionally test.vm.opts and test.java.opts system properties get prefixed to the opts that are passed for the process creation. That looks fine to me, for this test.

The current state of this PR in bd786b92 looks good to me. Thank you Naoto for the updates.

@naotoj
Copy link
Member Author

naotoj commented Sep 22, 2023

Thanks for all the reviews!

@naotoj
Copy link
Member Author

naotoj commented Sep 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit f7578e8.
Since your change was applied there have been 92 commits pushed to the master branch:

  • b66ded9: 8316688: Widen allowable error bound of Math.hypot
  • 6c61bc1: 8316514: Better diagnostic header for VtableStub
  • c90d631: 8315750: Update subtype check profile collection on PPC following 8308869
  • 00f585b: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • c24c66d: 8316681: Rewrite URLEncoder.encode to use small reusable buffers
  • bd2439f: 8316702: Only evaluate buffer when IGVPrintLevelOption >= 5
  • 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • ... and 82 more: https://git.openjdk.org/jdk/compare/f09b7af6851c725b0fc4d63832b52e17c4d24836...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@naotoj Pushed as commit f7578e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants