-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 #15832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…EL8 and Fedora 27
👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into |
Hello @yaqsun, for this PR to trigger the official review process, the title of this PR should match the JBS title. Can you update the PR title to |
Hello @yaqsun, thank you for fixing the title of this PR. It appears that additionally you have to fix some issues in the proposed code (tab usages) before this PR can generate a review request. Please take a look at the jcheck failure listed in the GitHub actions job of this PR. |
Webrevs
|
|
…EL8 and Fedora 27
|
Thank you for updating the patch! |
@yaqsun This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle, @sashamatveev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@yaqsun , I suggest you synchronize with the latest code and trigger testing before integration. |
I've synced to the latest code. |
/integrate |
/sponsor |
Going to push as commit 5281499.
Your commit was automatically rebased without conflicts. |
@alexeysemenyukoracle @yaqsun Pushed as commit 5281499. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test tools/jpackage/linux/LinuxResourceTest.java.
It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
But after 8314121, tools/jpackage/linux/LinuxResourceTest.java still reappears. tools/jpackage/linux/LinuxResourceTest.java does not use file src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.spec.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15832/head:pull/15832
$ git checkout pull/15832
Update a local copy of the PR:
$ git checkout pull/15832
$ git pull https://git.openjdk.org/jdk.git pull/15832/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15832
View PR using the GUI difftool:
$ git pr show -t 15832
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15832.diff
Webrev
Link to Webrev Comment