Skip to content

8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 #15832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Sep 20, 2023

on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test tools/jpackage/linux/LinuxResourceTest.java.
It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
But after 8314121, tools/jpackage/linux/LinuxResourceTest.java still reappears. tools/jpackage/linux/LinuxResourceTest.java does not use file src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.spec.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15832/head:pull/15832
$ git checkout pull/15832

Update a local copy of the PR:
$ git checkout pull/15832
$ git pull https://git.openjdk.org/jdk.git pull/15832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15832

View PR using the GUI difftool:
$ git pr show -t 15832

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15832.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2023

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@yaqsun The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 20, 2023
@jaikiran
Copy link
Member

Hello @yaqsun, for this PR to trigger the official review process, the title of this PR should match the JBS title. Can you update the PR title to 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

@yaqsun yaqsun changed the title 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on RHEL8 and Fedora 27 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Sep 28, 2023
@jaikiran
Copy link
Member

jaikiran commented Oct 3, 2023

Hello @yaqsun, thank you for fixing the title of this PR. It appears that additionally you have to fix some issues in the proposed code (tab usages) before this PR can generate a review request. Please take a look at the jcheck failure listed in the GitHub actions job of this PR.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2023

Webrevs

@alexeysemenyukoracle
Copy link
Member

%define _build_id_links none must be added to a spec file in LinuxResourceTest.java file. not on rpmbuild command line

@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 17, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2023
@yaqsun
Copy link
Contributor Author

yaqsun commented Oct 17, 2023

%define _build_id_links none must be added to a spec file in LinuxResourceTest.java file. not on rpmbuild command line

%define _build_id_links none has been added to a spec file in LinuxResourceTest.java file. Please review.

@alexeysemenyukoracle
Copy link
Member

Thank you for updating the patch!

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@yaqsun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

Reviewed-by: asemenyuk, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 8f5f440: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818
  • 684b91e: 8315064: j.text.ChoiceFormat provides no specification on quoting behavior
  • 1740950: 8314901: AES-GCM interleaved implementation using AVX2 instructions
  • cc8f8da: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • 599560a: 8317635: Improve GetClassFields test to verify correctness of field order
  • 9cf334f: 8318383: Remove duplicated checks in os::get_native_stack() in posix implementation
  • defc7e0: 8318454: TestLayoutPaths broken on Big Endian platforms after JDK-8317837
  • 3c70f2c: 8318418: hsdis build fails with system binutils on Ubuntu
  • 15acf4b: 8318324: Drop redundant default methods from FFM API
  • 1a09835: 8317358: G1: Make TestMaxNewSize use createTestJvm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle, @sashamatveev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 17, 2023
@theaoqi
Copy link
Member

theaoqi commented Oct 19, 2023

@yaqsun , I suggest you synchronize with the latest code and trigger testing before integration.

@yaqsun
Copy link
Contributor Author

yaqsun commented Oct 19, 2023

@yaqsun , I suggest you synchronize with the latest code and trigger testing before integration.

I've synced to the latest code.

@yaqsun
Copy link
Contributor Author

yaqsun commented Oct 20, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@yaqsun
Your change (at version d30af0e) is now ready to be sponsored by a Committer.

@alexeysemenyukoracle
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

Going to push as commit 5281499.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 8065233: 8318598: FFM stylistic cleanups
  • b1228de: 8314588: gc/metaspace/TestMetaspaceInitialization.java failed "assert(capacity_until_gc >= committed_bytes) failed: capacity_until_gc: 3145728 < committed_bytes: 3211264"
  • 5a97411: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics
  • 9144287: 8318601: Remove javadoc text about restricted methods
  • 4010642: 8077371: Binary files in JAXP test should be removed
  • fe52917: 8318457: Use prefix-less prepend methods directly to reduce branches in String concat expressions
  • 71c99a0: 8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913
  • 2c23391: 8318101: Additional test cases for CSSAttributeEqualityBug
  • deadb9c: 8304684: Memory leak in DirectivesParser::set_option_flag
  • a03767c: 8318049: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN
  • ... and 25 more: https://git.openjdk.org/jdk/compare/47bb1a1cefa242c39c22a8f2aa08d7d357c260b9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2023
@openjdk openjdk bot closed this Oct 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@alexeysemenyukoracle @yaqsun Pushed as commit 5281499.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yaqsun yaqsun deleted the 8316563 branch October 21, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants