8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product

[tschatzl]

Hi all,

please review this change to fix a memory leak I found when having CodeCache::free call the destructor of CodeBlob: when adding the latter, one gets assertion failures that the native memory that _asm_remarks and _dbg_strings members were not deallocated properly when

• stopping a compiler thread due to dynamic compiler thread policy
• shutting down the compiler runtime

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product (Bug - P3)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15858/head:pull/15858
$ git checkout pull/15858

Update a local copy of the PR:
$ git checkout pull/15858
$ git pull https://git.openjdk.org/jdk.git pull/15858/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15858

View PR using the GUI difftool:
$ git pr show -t 15858

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15858.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a489c430)
• 00: Full (6256b301)

[vnkozlov]

Agree. This is good cleanup.

[TobiHartmann]

Looks good to me.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

• 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
• 347bd15: 8315966: Relativize initial_sp in interpreter frames
• b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
• ad6df41: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
• 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
• 50a7a04: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists
• fee9d33: 8293176: SSLEngine handshaker does not send an alert after a bad parameters
• fd52be2: 8316895: SeenThread::print_action_queue called on a null pointer
• e39197e: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
• b659e03: 8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547
• ... and 100 more: https://git.openjdk.org/jdk/compare/ec74194cb75afcaab2f77e8728391bb9104ccc73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Good.

[tschatzl]

Thanks @vnkozlov @TobiHartmann for your reviews
/integrate

[openjdk]

Going to push as commit edcc559.
Since your change was applied there have been 110 commits pushed to the master branch:

• 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
• 347bd15: 8315966: Relativize initial_sp in interpreter frames
• b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
• ad6df41: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
• 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
• 50a7a04: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists
• fee9d33: 8293176: SSLEngine handshaker does not send an alert after a bad parameters
• fd52be2: 8316895: SeenThread::print_action_queue called on a null pointer
• e39197e: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
• b659e03: 8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547
• ... and 100 more: https://git.openjdk.org/jdk/compare/ec74194cb75afcaab2f77e8728391bb9104ccc73...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit edcc559.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.