Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316146: Open some swing tests 4 #15875

Closed
wants to merge 11 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Sep 21, 2023

Opening closed tests:
12 javax/swing/ToolTipManager/5078214/bug5078214.java
13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
15 javax/swing/plaf/metal/4306431/bug4306431.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15875/head:pull/15875
$ git checkout pull/15875

Update a local copy of the PR:
$ git checkout pull/15875
$ git pull https://git.openjdk.org/jdk.git pull/15875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15875

View PR using the GUI difftool:
$ git pr show -t 15875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15875.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2023

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 21, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2023

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for some minor nits as mentioned below.

test/jdk/javax/swing/BasicMenuUI/bug4244616.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/BasicMenuUI/bug4244616.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/BasicMenuUI/bug4244616.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/LookAndFeel/bug4306431.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/LookAndFeel/bug4306431.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/BasicMenuUI/bug4244616.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/BasicMenuUI/bug4244616.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/ToolTipManager/bug5078214.java Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316146: Open some swing tests 4

Reviewed-by: honkar, aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 394 new commits pushed to the master branch:

  • 4195246: 8317354: Serial: Move DirtyCardToOopClosure to gc/serial folder
  • 0a3a925: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • b0d6c84: 8316396: Endless loop in C2 compilation triggered by AddNode::IdealIL
  • a8549b6: 8280120: [IR Framework] Add attribute to @ir to enable/disable IR matching based on the architecture
  • 9718f49: 8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers.
  • 0d4de8a: 8316971: Add Lint warning for restricted method calls
  • d4c904d: 8317294: Classloading throws exceptions over already pending exceptions
  • 48f1a92: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0b0f8b5: 8219652: [aix] Tests failing with JNI attach problems.
  • 8c0d026: 8315042: NPE in PKCS7.parseOldSignedData
  • ... and 384 more: https://git.openjdk.org/jdk/compare/024133b089d911dcc3ea70dfdaa6b150b14a9eb4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2023
@honkar-jdk
Copy link
Contributor

honkar-jdk commented Oct 2, 2023

@alisenchung Looks like Util.blockTillDisplayed(mainFrame) has been removed which was causing compilation issues earlier. Now the updated test works correctly.

@DamonGuy
Copy link
Contributor

DamonGuy commented Oct 2, 2023

@alisenchung Looks like Util.blockTillDisplayed(mainFrame) has been removed which was causing compilation issues earlier. Now the updated test works correctly.

Yep. This sounds correct. I did something similar here in bug4703690.java in #15747.

@aivanov-jdk
Copy link
Member

@alisenchung Looks like Util.blockTillDisplayed(mainFrame) has been removed which was causing compilation issues earlier. Now the updated test works correctly.

Ah, the test didn't compile earlier…

@alisenchung
Copy link
Contributor Author

testing is green now on mach5

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes look good.

@alisenchung
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

Going to push as commit 3105538.
Since your change was applied there have been 396 commits pushed to the master branch:

  • 36314a9: 8267509: Improve IllegalAccessException message to include the cause of the exception
  • ddacf92: 8305765: CompressedClassPointers.java is unreliable due to ASLR
  • 4195246: 8317354: Serial: Move DirtyCardToOopClosure to gc/serial folder
  • 0a3a925: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • b0d6c84: 8316396: Endless loop in C2 compilation triggered by AddNode::IdealIL
  • a8549b6: 8280120: [IR Framework] Add attribute to @ir to enable/disable IR matching based on the architecture
  • 9718f49: 8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers.
  • 0d4de8a: 8316971: Add Lint warning for restricted method calls
  • d4c904d: 8317294: Classloading throws exceptions over already pending exceptions
  • 48f1a92: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • ... and 386 more: https://git.openjdk.org/jdk/compare/024133b089d911dcc3ea70dfdaa6b150b14a9eb4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2023
@openjdk openjdk bot closed this Oct 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@alisenchung Pushed as commit 3105538.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants