-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8316698: build failure caused by JDK-8316456 #15876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
dcubed-ojdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up. This is a trivial fix.
|
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
/integrate |
|
Going to push as commit a1e0346. |
JDK-8316456 causes hotspot build to fail due to an extra argument passed to log_debug. Trivial fix.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15876/head:pull/15876$ git checkout pull/15876Update a local copy of the PR:
$ git checkout pull/15876$ git pull https://git.openjdk.org/jdk.git pull/15876/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15876View PR using the GUI difftool:
$ git pr show -t 15876Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15876.diff
Webrev
Link to Webrev Comment