-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316702: Only evaluate buffer when IGVPrintLevelOption >= 5 #15878
Conversation
👋 Welcome back xliu! A progress list of the required criteria for merging this PR into |
The only failure is gc/TestAllocHumongousFragment#aggressive on macos-x86. I don't think it's related to this chagne. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, looks good!
@navyxliu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 77 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
tThanks for reviewing this. |
/integrate |
Going to push as commit bd2439f.
Your commit was automatically rebased without conflicts. |
This is a follow-up of JDK-8310220. hotspot C2 only emits IR per bytecode to IGV when level = 5.
Currently, we conservatively check C->should_print_igv(1) in Parse::do_one_bytecode(). It's wasteful when level>1 and <= 4. We evaluate
jio_snprintf(buffer, sizeof(buffer), "Bytecode %d: %s", bci(), Bytecodes::name(bc()))
for each bytecode but emit nothing.We should use the same level(5) in those 2 places.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15878/head:pull/15878
$ git checkout pull/15878
Update a local copy of the PR:
$ git checkout pull/15878
$ git pull https://git.openjdk.org/jdk.git pull/15878/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15878
View PR using the GUI difftool:
$ git pr show -t 15878
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15878.diff
Webrev
Link to Webrev Comment