Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316702: Only evaluate buffer when IGVPrintLevelOption >= 5 #15878

Closed
wants to merge 1 commit into from

Conversation

navyxliu
Copy link
Member

@navyxliu navyxliu commented Sep 22, 2023

This is a follow-up of JDK-8310220. hotspot C2 only emits IR per bytecode to IGV when level = 5.

Currently, we conservatively check C->should_print_igv(1) in Parse::do_one_bytecode(). It's wasteful when level>1 and <= 4. We evaluate jio_snprintf(buffer, sizeof(buffer), "Bytecode %d: %s", bci(), Bytecodes::name(bc())) for each bytecode but emit nothing.

We should use the same level(5) in those 2 places.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316702: Only evaluate buffer when IGVPrintLevelOption >= 5 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15878/head:pull/15878
$ git checkout pull/15878

Update a local copy of the PR:
$ git checkout pull/15878
$ git pull https://git.openjdk.org/jdk.git pull/15878/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15878

View PR using the GUI difftool:
$ git pr show -t 15878

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15878.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@navyxliu The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@navyxliu
Copy link
Member Author

The only failure is gc/TestAllocHumongousFragment#aggressive on macos-x86. I don't think it's related to this chagne.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looks good!

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316702: Only evaluate buffer when IGVPrintLevelOption >= 5

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
  • a1e0346: 8316698: build failure caused by JDK-8316456
  • c72f004: 8316456: StackWalker may skip Continuation::yield0 frame mistakenly
  • 041510d: 8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out
  • ef49e6c: 8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful
  • 496264c: 8316435: sun.util.calendar.CalendarSystem subclassing should be restricted
  • 1100dbc: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
  • ... and 67 more: https://git.openjdk.org/jdk/compare/3760a0448df7024f9b44fa2af11007de4dfcbbe2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2023
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@navyxliu
Copy link
Member Author

tThanks for reviewing this.

@navyxliu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit bd2439f.
Since your change was applied there have been 78 commits pushed to the master branch:

  • 4b65483: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • 7352bb9: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 343cc0c: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • fe86263: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 775e22a: 8316699: TestDynamicConstant.java fails with release VMs
  • a1e0346: 8316698: build failure caused by JDK-8316456
  • c72f004: 8316456: StackWalker may skip Continuation::yield0 frame mistakenly
  • 041510d: 8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out
  • ef49e6c: 8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful
  • 496264c: 8316435: sun.util.calendar.CalendarSystem subclassing should be restricted
  • ... and 68 more: https://git.openjdk.org/jdk/compare/3760a0448df7024f9b44fa2af11007de4dfcbbe2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@navyxliu Pushed as commit bd2439f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants