Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257617: TestLinkPlatform fails with new Java source version #1588

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Dec 3, 2020

This fixes the problem that some tests in TestLinkPlatform.java rely on a static list of properties, causing them to fail when a new Java source version is added. The solution is to create the properties file on the fly.

I also replaced the custom documentation domain with "example.com" as suggested in the original PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257617: TestLinkPlatform fails with new Java source version

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1588/head:pull/1588
$ git checkout pull/1588

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 3, 2020

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label Dec 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 3, 2020

Webrevs

jddarcy
jddarcy approved these changes Dec 3, 2020
Copy link
Member

@jddarcy jddarcy left a comment

Thanks for the fix. The test passes with this change when run in my in-development JDK 17 build.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257617: TestLinkPlatform fails with new Java source version

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 3, 2020
@hns
Copy link
Member Author

@hns hns commented Dec 3, 2020

/integrate

@openjdk openjdk bot closed this Dec 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@hns Pushed as commit a5a034b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated javadoc
2 participants