Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java #15880

Closed
wants to merge 3 commits into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 22, 2023

Exclude java/awt/font/Rotate/RotatedTextTest.java until JDK-8219641 is fixed. The error shows in several linux installations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15880/head:pull/15880
$ git checkout pull/15880

Update a local copy of the PR:
$ git checkout pull/15880
$ git pull https://git.openjdk.org/jdk.git pull/15880/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15880

View PR using the GUI difftool:
$ git pr show -t 15880

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15880.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@RealCLanger To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@RealCLanger
Copy link
Contributor Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@RealCLanger
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java

Reviewed-by: mbaesken, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
  • 50a7a04: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2023
@RealCLanger
Copy link
Contributor Author

Thanks Alexey!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

Going to push as commit ad6df41.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
  • 50a7a04: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2023
@openjdk openjdk bot closed this Sep 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@RealCLanger Pushed as commit ad6df41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the JDK-8316710 branch September 27, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants