Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently #15882

Closed
wants to merge 3 commits into from

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 22, 2023

increase Metaspace size and loop count to avoid OOME in nominal case


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15882/head:pull/15882
$ git checkout pull/15882

Update a local copy of the PR:
$ git checkout pull/15882
$ git pull https://git.openjdk.org/jdk.git pull/15882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15882

View PR using the GUI difftool:
$ git pr show -t 15882

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15882.diff

Webrev

Link to Webrev Comment

…ava fails intermittently

increase Metaspace size and loop count to avoid OOME in nominal case
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@jpbempel The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 22, 2023
@jpbempel jpbempel marked this pull request as ready for review September 22, 2023 12:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay if it helps the test run reliably. I don't know a better way to test the absence of a memory leak. If this fails again, maybe we need to rewrite RedefineClassHelper to only generate the class bytes once, not each time.
This is a trivial change and seems to already have David's implicit approval in the CR, so I don't think you need to wait 24 hours. You can if you want though.

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 83806ab: 6450193: After the first Serialization, JTableHeader does not uninstall its UI
  • 2f311d5: 8316211: Open source several manual applet tests
  • 65227a3: 8316389: Open source few AWT applet tests
  • 788e6e1: 8316218: Open some swing tests 5
  • ee9776f: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper
  • 36ac839: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable
  • efb7e85: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 4e1e579: 8315920: C2: "control input must dominate current control" assert failure
  • 1f7dfda: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
  • 20ff603: 8316735: Print LockStack in hs_err files
  • ... and 39 more: https://git.openjdk.org/jdk/compare/7352bb910506b7d22b4d3860223fb933295eab14...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2023
@jpbempel
Copy link
Member Author

Thanks!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@jpbempel
Your change (at version 157ef53) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

Hold on! I tested a change to 17M only. Sure 24M will work fine to avoid the OOM, but does it still fail without the original fix? The boost to 1000 iterations is untested and may lead to new failures, so I will have to re-test this again before it is integrated.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test still fails with these new settings. As per JBS I found 17m worked fine with the existing iterations and still caused an unfixed VM to fail. With 24M and 500 iterations the unfixed VM passes.

@dholmes-ora
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Sep 24, 2023

@dholmes-ora
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Sep 24, 2023
@jpbempel
Copy link
Member Author

On my side, 17M with 500 iterations on an unpatched VM does not fail.
That's why I have boosted the number of iterations and increased the Metaspace to magnify the leak and also avoid fixed cost of loading test infrastructure into Metaspace.
I have tested 17M/700 iterations successfully

@dholmes-ora
Copy link
Member

Re-testing at 17M/700

@dholmes-ora
Copy link
Member

Okay 17M/700 seems to work okay in our CI, and fails without the fix.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 26, 2023
@jpbempel
Copy link
Member Author

Thanks!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@jpbempel
Your change (at version 12fda8c) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit 84390dd.
Since your change was applied there have been 66 commits pushed to the master branch:

  • 52073b2: 8316994: Avoid modifying ClassLoader and Module objects during -Xshare:dump
  • 83c0e45: 8306630: Bump minimum boot jdk to JDK 21
  • d3a79b5: 8316371: Open some swing tests 6
  • 750da00: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
  • 5350fd6: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization
  • edcc559: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
  • 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • 347bd15: 8315966: Relativize initial_sp in interpreter frames
  • b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
  • ... and 56 more: https://git.openjdk.org/jdk/compare/7352bb910506b7d22b4d3860223fb933295eab14...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@dholmes-ora @jpbempel Pushed as commit 84390dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants