Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251843: jfr/tool/ fails intermittently #1589

wants to merge 4 commits into from


Copy link

@egahlin egahlin commented Dec 3, 2020

The 'jfr' tool can print events in JSON and XML and the result is verified by reading the same file using the jdk.jfr.consumer API. The method RecordedEvent::getEndTime() exposes timestamps with nano-precision (java.time.Instant), while the tool sorts them according to ticks. It is believed that events with different ticks timestamp in some circumstances may get the same nano-precision timestamp. This leads to events not arriving in the same order and the test fails.

Fix is to sort events in the test by ticks as well


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8251843: jfr/tool/ fails intermittently



$ git fetch pull/1589/head:pull/1589
$ git checkout pull/1589

Copy link

bridgekeeper bot commented Dec 3, 2020

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link

openjdk bot commented Dec 3, 2020

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-jfr rfr Pull request is ready for review labels Dec 3, 2020
Copy link

mlbridge bot commented Dec 3, 2020


@egahlin egahlin marked this pull request as draft December 3, 2020 08:36
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 3, 2020
@egahlin egahlin marked this pull request as ready for review December 3, 2020 11:22
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2020
Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

openjdk bot commented Dec 3, 2020

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8251843: jfr/tool/ fails intermittently

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • e29ee5b: 8257641: Shenandoah: Query is_at_shenandoah_safepoint() from control thread should return false
  • 55f5542: 8026976: ECParameters, Point does not match field size
  • d3f3c32: 8255742: PrintInlining as compiler directive doesn't print virtual calls
  • 6c9482e: 8257561: Some code is not vectorized after 8251925 and 8250607
  • 70517c8: 8257642: CipherByteBufferOverwriteTest copyright issue
  • e836396: 8257436: [aarch64] Regressions in ArrayCopyUnalignedDst.testByte/testChar for 65-78 bytes when UseSIMDForMemoryOps is on
  • b170c83: 8257591: Remove suppression of record preview related warnings in java.lang
  • 66a2e70: 8255845: Memory leak in imageFile.cpp
  • fa58671: 8257020: [JVMCI] enable a JVMCICompiler to specify which GCs it supports
  • 129c377: 8257594: C2 compiled checkcast of non-null object triggers endless deoptimization/recompilation cycle
  • ... and 7 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2020
Copy link
Member Author

egahlin commented Dec 4, 2020


@openjdk openjdk bot closed this Dec 4, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2020
Copy link

openjdk bot commented Dec 4, 2020

@egahlin Since your change was applied there have been 40 commits pushed to the master branch:

  • c6f93ec: 8257707: Fix incorrect format string in Http1HeaderParser
  • fbdc187: 8257624: C2: PhaseMacroExpand::eliminate_macro_nodes() crashes on out-of-bounds access into macro node array
  • fd6756e: 8257634: C2: Introduce IncrementalInliningForceCleanup diagnostic flag
  • af6b7f9: 8257743: Minimal build on AArch64 failed with --disable-precompiled-headers
  • d6dd440: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 2b4a423: 8255542: Attribute length of Module, ModulePackages and other attributes is ignored
  • ca40267: 8257509: Strengthen requirements to call G1HeapVerifier::verify(VerifyOption)
  • 4a85514: 8257182: JCK test failures in integer / long rotation tests
  • f33808f: 8257631: C2: Assertion failure in ArrayCopyNode::get_count() during late inlining
  • 417e7e6: 8257632: C2: Late inlining attempt on a call with a dead memory crashes
  • ... and 30 more:

Your commit was automatically rebased without conflicts.

Pushed as commit feabdde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-jfr integrated Pull request has been integrated
2 participants