Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning #15890

Conversation

Ilyagavrilin
Copy link

@Ilyagavrilin Ilyagavrilin commented Sep 22, 2023

Please review this small change for UseVectorizedMismatchIntrinsic option.
On RISC-V we do not have VectorizedMismatch intrinsic, so void LIRGenerator::do_vectorizedMismatch(Intrinsic* x) prodeuces fatal error when this option turned on.
Other similar options (like -XX:+UseCRC32Intrinsics) produces only warning:

if (UseSHA) {
warning("SHA instructions are not available on this CPU");
FLAG_SET_DEFAULT(UseSHA, false);
}
if (UseSHA1Intrinsics) {
warning("Intrinsics for SHA-1 crypto hash functions not available on this CPU.");
FLAG_SET_DEFAULT(UseSHA1Intrinsics, false);
}
if (UseSHA256Intrinsics) {
warning("Intrinsics for SHA-224 and SHA-256 crypto hash functions not available on this CPU.");
FLAG_SET_DEFAULT(UseSHA256Intrinsics, false);
}
if (UseSHA512Intrinsics) {
warning("Intrinsics for SHA-384 and SHA-512 crypto hash functions not available on this CPU.");
FLAG_SET_DEFAULT(UseSHA512Intrinsics, false);
}
if (UseSHA3Intrinsics) {
warning("Intrinsics for SHA3-224, SHA3-256, SHA3-384 and SHA3-512 crypto hash functions not available on this CPU.");
FLAG_SET_DEFAULT(UseSHA3Intrinsics, false);
}
if (UseCRC32Intrinsics) {
warning("CRC32 intrinsics are not available on this CPU.");
FLAG_SET_DEFAULT(UseCRC32Intrinsics, false);
}
if (UseCRC32CIntrinsics) {
warning("CRC32C intrinsics are not available on this CPU.");
FLAG_SET_DEFAULT(UseCRC32CIntrinsics, false);
}

Also, on platforms, where VectorizedMismatch unimplemented to we got warning.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15890/head:pull/15890
$ git checkout pull/15890

Update a local copy of the PR:
$ git checkout pull/15890
$ git pull https://git.openjdk.org/jdk.git pull/15890/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15890

View PR using the GUI difftool:
$ git pr show -t 15890

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15890.diff

Webrev

Link to Webrev Comment

Before, when we tried to set UseVectroizedMismatchIntrinsic option on RISC-V we got fatal error, change it to warning and UseVectroizedMismatchIntrinsic=false.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back igavrilin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@Ilyagavrilin The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 23, 2023

@Ilyagavrilin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 372 new commits pushed to the master branch:

  • b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
  • 5350fd6: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization
  • edcc559: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
  • 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • 347bd15: 8315966: Relativize initial_sp in interpreter frames
  • b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
  • ad6df41: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
  • 50a7a04: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists
  • fee9d33: 8293176: SSLEngine handshaker does not send an alert after a bad parameters
  • ... and 362 more: https://git.openjdk.org/jdk/compare/29ff1e45b910c07711c4f4c3d821712dd9a1e3ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @luhenry) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2023
@Ilyagavrilin
Copy link
Author

/integrate

@VladimirKempik
Copy link

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@Ilyagavrilin
Your change (at version 56c4473) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

Going to push as commit 750da00.
Since your change was applied there have been 372 commits pushed to the master branch:

  • b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
  • 5350fd6: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization
  • edcc559: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
  • 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • 347bd15: 8315966: Relativize initial_sp in interpreter frames
  • b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
  • ad6df41: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
  • 50a7a04: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists
  • fee9d33: 8293176: SSLEngine handshaker does not send an alert after a bad parameters
  • ... and 362 more: https://git.openjdk.org/jdk/compare/29ff1e45b910c07711c4f4c3d821712dd9a1e3ba...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2023
@openjdk openjdk bot closed this Sep 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@VladimirKempik @Ilyagavrilin Pushed as commit 750da00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
5 participants