-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316771: Krb5.java has not defined messages for all error codes #15892
Conversation
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
public static final int KRB_AP_ERR_NOREALM = 62; | ||
public static final int KRB_AP_ERR_GEN_CRED = 63; | ||
|
||
public static final int KRB_CRYPTO_NOT_SUPPORT = 100; //Client does not support this crypto type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, and not a specific review comment, but do you know if this error code is necessary? It isn't defined in RFC 4120 and not used in the JDK AFAICT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's useless. There are several other error codes that are also used nowhere (Ex: BITSTRING_SIZE_INVALID
). Maybe they were used long time ago, or maybe the original contributor used them in some other places and they had not cleaned up.
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 220 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d7d1d42.
Your commit was automatically rebased without conflicts. |
Added 4 missing error codes and removed 2 wrong ones.
KRB_AP_ERR_NOREALM claims itself to be "used in setDefaultCreds() in sun.security.krb5.Credentials" but it's no more.
KRB_AP_ERR_GEN_CRED is used in one place but it's a local error and not meant to be embedded in a message. Therefore safe to be removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15892/head:pull/15892
$ git checkout pull/15892
Update a local copy of the PR:
$ git checkout pull/15892
$ git pull https://git.openjdk.org/jdk.git pull/15892/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15892
View PR using the GUI difftool:
$ git pr show -t 15892
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15892.diff
Webrev
Link to Webrev Comment