Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316851: Add @sealedGraph to Executable #15897

Closed
wants to merge 2 commits into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Sep 25, 2023

This PR proposes to add the @sealedGraph tag to java.lang.reflect.Executable.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316851: Add @sealedGraph to Executable (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15897/head:pull/15897
$ git checkout pull/15897

Update a local copy of the PR:
$ git checkout pull/15897
$ git pull https://git.openjdk.org/jdk.git pull/15897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15897

View PR using the GUI difftool:
$ git pr show -t 15897

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15897.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 25, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2023

Webrevs

Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyright year before pushing.

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316851: Add @sealedGraph to Executable

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 3fe6e0f: 8308479: [s390x] Implement alternative fast-locking scheme
  • e2e8e8e: 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing
  • 0dce4c1: 8313220: Remove Windows specific workaround in LCMS.c for _snprintf
  • e5f05b5: 8312191: ColorConvertOp.filter for the default destination is too slow
  • be9cc73: 8315871: Opensource five more Swing regression tests
  • b65f4f7: 8313403: Remove unused 'mask' field from JFormattedTextField
  • e3201d1: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
  • 9291b46: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system
  • afa4833: 8271268: Fix Javadoc links for Stream.mapMulti
  • 9688ec2: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
  • ... and 3 more: https://git.openjdk.org/jdk/compare/3d6e775d7135919519a9748036cd20b6c130bb42...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2023
@minborg
Copy link
Contributor Author

minborg commented Sep 26, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

Going to push as commit 9e6cb62.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 3fe6e0f: 8308479: [s390x] Implement alternative fast-locking scheme
  • e2e8e8e: 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing
  • 0dce4c1: 8313220: Remove Windows specific workaround in LCMS.c for _snprintf
  • e5f05b5: 8312191: ColorConvertOp.filter for the default destination is too slow
  • be9cc73: 8315871: Opensource five more Swing regression tests
  • b65f4f7: 8313403: Remove unused 'mask' field from JFormattedTextField
  • e3201d1: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
  • 9291b46: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system
  • afa4833: 8271268: Fix Javadoc links for Stream.mapMulti
  • 9688ec2: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
  • ... and 3 more: https://git.openjdk.org/jdk/compare/3d6e775d7135919519a9748036cd20b6c130bb42...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2023
@openjdk openjdk bot closed this Sep 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@minborg Pushed as commit 9e6cb62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants