Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8220483: Calendar.setTime(Date date) throws NPE with Date date = null #159

Closed
wants to merge 1 commit into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Sep 14, 2020

Hi,

Please review this simple doc fix.

/issue add 8220483
/csr needed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8220483: Calendar.setTime(Date date) throws NPE with Date date = null

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/159/head:pull/159
$ git checkout pull/159

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2020

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@naotoj This issue is referenced in the PR title - it will now be updated.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@naotoj The command csr cannot be used in the pull request body. Please use it in a new comment.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@naotoj The following labels will be automatically applied to this pull request: core-libs i18n.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@naotoj
Copy link
Member Author

@naotoj naotoj commented Sep 14, 2020

/csr needed

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@naotoj this pull request will not be integrated until the CSR request JDK-8253140 for issue JDK-8220483 has been approved.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2020

Webrevs

Loading

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Hi Naoto,

The change looks fine. I might have created a CSR just to track the doc change.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@naotoj This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8220483: Calendar.setTime(Date date) throws NPE with Date date = null

Reviewed-by: lancea, joehw
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 17 commits pushed to the master branch:

  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/9c24a5635ee4caa81fef2f49c1f323d86ddc02c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 65bfe0928af3de1811bfc445fa4bfc0b117f3b96.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 14, 2020
@JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Sep 14, 2020

The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone​(TimeZone value), getInstance​(Locale aLocale), etc.? Or, would it better to add a general statement about passing in null values?

Loading

@naotoj
Copy link
Member Author

@naotoj naotoj commented Sep 14, 2020

Thanks, Lance,

The change looks fine. I might have created a CSR just to track the doc change.

Yes, and thanks for the CSR review too!

Loading

@naotoj
Copy link
Member Author

@naotoj naotoj commented Sep 14, 2020

Thanks, Joe.

The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone​(TimeZone value), getInstance​(Locale aLocale), etc.? Or, would it better to add a general statement about passing in null values?

Those two methods describe the NPE correctly. There are other locations that may have missed the @throws tag, but I would rather fix this specific one this time (for my GitHub training :-)

Loading

@JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Sep 14, 2020

That makes sense (good start for the 1st PR ;-)).

Loading

@openjdk openjdk bot removed the csr label Sep 15, 2020
@naotoj
Copy link
Member Author

@naotoj naotoj commented Sep 15, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@naotoj Since your change was applied there have been 17 commits pushed to the master branch:

  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/9c24a5635ee4caa81fef2f49c1f323d86ddc02c6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 57f92d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Sep 15, 2020
@naotoj naotoj deleted the misc branch Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants