New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8220483: Calendar.setTime(Date date) throws NPE with Date date = null #159
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
@naotoj This issue is referenced in the PR title - it will now be updated. |
@naotoj The command |
@naotoj The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
/csr needed |
@naotoj this pull request will not be integrated until the CSR request JDK-8253140 for issue JDK-8220483 has been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Naoto,
The change looks fine. I might have created a CSR just to track the doc change.
@naotoj This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 17 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
The change looks fine. However, are other methods in the same situation, e.g. void setTimeZone(TimeZone value), getInstance(Locale aLocale), etc.? Or, would it better to add a general statement about passing in null values? |
Thanks, Lance,
Yes, and thanks for the CSR review too! |
Thanks, Joe.
Those two methods describe the NPE correctly. There are other locations that may have missed the @throws tag, but I would rather fix this specific one this time (for my GitHub training :-) |
That makes sense (good start for the 1st PR ;-)). |
/integrate |
@naotoj Since your change was applied there have been 17 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 57f92d2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Please review this simple doc fix.
/issue add 8220483
/csr needed
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/159/head:pull/159
$ git checkout pull/159