8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled

[egahlin]

Clarify that an InputStream can't be returned when calling Recording::getStream() on an in memory recording.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled

Reviewers

• Markus Grönlund (@mgronlun - Reviewer) ⚠️ Review applies to c5ed979

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1592/head:pull/1592
$ git checkout pull/1592

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (af9038e)
• 01: Full - Incremental (17fbf25)
• 00: Full (c5ed979)

[mgronlun]

Looks good.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• 566d77a: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"
• f5a582c: 8257575: C2: "failed: only phis" assert failure in loop strip mining verification
• d05401d: 8256679: Update serialization javadoc once JOSS changes for records are complete
• 7620124: 8257230: assert(InitialHeapSize >= MinHeapSize) failed: Ergonomics decided on incompatible initial and minimum heap sizes
• 05dac03: 8257803: Add -Xbatch to compiler/blackhole tests
• 29a09c8: 8257668: SA JMap - skip non-java thread stack dump for heap dump
• e590618: 8252505: C1/C2 compiler support for blackholes
• 972bc3b: 8256167: Convert JDK use of Reference::get to Reference::refersTo
• 78be334: 8242332: Add SHA3 support to SunPKCS11 provider
• c4339c3: 8243614: Typo in ReentrantLock's Javadoc
• ... and 47 more: https://git.openjdk.java.net/jdk/compare/4a267f1bc2b025aae2cb9df7283156aeb0282406...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

@egahlin Since your change was applied there have been 60 commits pushed to the master branch:

• 04ce8e3: 8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle
• 5a03e47: 8255560: Class::isRecord should check that the current class is final and not abstract
• 8e8e584: 8257588: Make os::_page_sizes a bitmask
• 566d77a: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"
• f5a582c: 8257575: C2: "failed: only phis" assert failure in loop strip mining verification
• d05401d: 8256679: Update serialization javadoc once JOSS changes for records are complete
• 7620124: 8257230: assert(InitialHeapSize >= MinHeapSize) failed: Ergonomics decided on incompatible initial and minimum heap sizes
• 05dac03: 8257803: Add -Xbatch to compiler/blackhole tests
• 29a09c8: 8257668: SA JMap - skip non-java thread stack dump for heap dump
• e590618: 8252505: C1/C2 compiler support for blackholes
• ... and 50 more: https://git.openjdk.java.net/jdk/compare/4a267f1bc2b025aae2cb9df7283156aeb0282406...master

Your commit was automatically rebased without conflicts.

Pushed as commit 09707dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.