JDK-8219652: [aix] Tests failing with JNI attach problems. #15924

varada1110 · 2023-09-26T13:49:02Z

Similar issue JDK-8303549 where AttachCurrentThread is failing on AIX due to stack size issue.
Test cases:
runtime/jni/terminatedThread/TestTerminatedThread.java
vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java
vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/TestDescription.java
vmTestbase/nsk/jvmti/SetJNIFunctionTable/setjniftab001/TestDescription.java

Reported Issue : JDK-8219652

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8219652: [aix] Tests failing with JNI attach problems. (Bug - P4)

Reviewers

David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 44e2c8f3
Chris Plummer (@plummercj - Reviewer)
Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15924/head:pull/15924
$ git checkout pull/15924

Update a local copy of the PR:
$ git checkout pull/15924
$ git pull https://git.openjdk.org/jdk.git pull/15924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15924

View PR using the GUI difftool:
$ git pr show -t 15924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15924.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-09-26T13:50:53Z

👋 Welcome back varada1110! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-09-26T13:52:51Z

@varada1110 The following labels will be automatically applied to this pull request:

hotspot-runtime
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-09-26T13:57:37Z

Webrevs

test/hotspot/jtreg/ProblemList.txt

test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/ji06t001.cpp

plummercj · 2023-09-26T16:08:56Z

It seems for some of the fixes instead of making sure the current thread has sufficient stack space , you instead create a new thread with sufficient stack space to attach to. Is there a reason the original thread could not have been created with enough stack space?

test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetJNIFunctionTable/setjniftab001/setjniftab001.cpp

dholmes-ora

You should be changing the thread creation logic in ./nsk/share/native/native_thread.cpp for the nsk test changes.

Thanks

This reverts commit b2648f0.

varada1110 · 2023-09-27T08:15:58Z

You should be changing the thread creation logic in ./nsk/share/native/native_thread.cpp for the nsk test changes.

Thanks

Thank you @dholmes-ora .I have applied changes there. Please review the code change

dholmes-ora

That is much cleaner and simpler - thanks.

A couple of minor nits, plus the ProblemList fixing that Chris mentioned.

test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.cpp

dholmes-ora

That all looks fine to me.

Thanks.

openjdk · 2023-09-28T06:39:36Z

⚠️ @varada1110 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout AttachCurrentThread
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

openjdk · 2023-09-28T06:39:37Z

@varada1110 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8219652: [aix] Tests failing with JNI attach problems.

Reviewed-by: dholmes, cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 285 new commits pushed to the master branch:

47569a2: 8295919: java.security.MessageDigest.isEqual does not adhere to @implNote
5a6aa56: 8303959: tools/jpackage/share/RuntimePackageTest.java fails with java.lang.AssertionError missing files
014c95a: 8317126: Redundant entries in Windows tzmappings file
fa0697a: 8316998: Remove redundant type arguments in the java.util.stream package
49376e4: 8316000: File.setExecutable silently fails if file does not exist
a185be0: 8317139: [JVMCI] oop handles clearing message pollutes event log
179792b: 8317283: jpackage tests run osx-specific checks on windows and linux
bd918f4: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
c45308a: 8301327: convert assert to guarantee in Handle_IDiv_Exception
bd7bb67: 8317257: RISC-V: llvm build broken
... and 275 more: https://git.openjdk.org/jdk/compare/fda142ff6cfefa12ec1ea4d4eb48b3c1b285bc04...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @plummercj, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

plummercj · 2023-09-28T14:25:16Z

Copyrights need updating.

Can you tell me what testing you've done?

varada1110 · 2023-09-28T16:38:07Z

Copyrights need updating.

Can you tell me what testing you've done?

I have performed jtreg testing

plummercj · 2023-09-28T18:07:20Z

I have performed jtreg testing

Yes, but what testing and on which platforms?

plummercj · 2023-09-28T23:46:52Z

I just ran the changes through our tier1 CI and also ran all the nsk/jvmti tests on all supported platforms and everything passed, so I think the changes are good.

varada1110 · 2023-09-29T06:03:58Z

I just ran the changes through our tier1 CI and also ran all the nsk/jvmti tests on all supported platforms and everything passed, so I think the changes are good.

I performed tests on AIX 7.2. Thank you @plummercj for checking on all platforms

varada1110 · 2023-09-29T06:04:37Z

/integrate

openjdk · 2023-09-29T06:05:44Z

@varada1110
Your change (at version 848d4d8) is now ready to be sponsored by a Committer.

sspitsyn

Looks good.
Thanks,
Serguei

offamitkumar · 2023-10-04T06:05:38Z

/sponsor

openjdk · 2023-10-04T06:07:16Z

Going to push as commit 0b0f8b5.
Since your change was applied there have been 323 commits pushed to the master branch:

8c0d026: 8315042: NPE in PKCS7.parseOldSignedData
f7deaf4: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
8ff10a0: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
1809b8c: 8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException.
cfabcbf: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
b859da9: 8316696: Remove the testing base classes: IntlTest and CollatorTest
b438cff: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state
ae796a4: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi
89987db: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code
0e501f6: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads"
... and 313 more: https://git.openjdk.org/jdk/compare/fda142ff6cfefa12ec1ea4d4eb48b3c1b285bc04...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-10-04T06:07:26Z

@offamitkumar @varada1110 Pushed as commit 0b0f8b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

AttachCurrentThread() failure solution

b2648f0

openjdk bot added the rfr Pull request is ready for review label Sep 26, 2023

openjdk bot added serviceability serviceability-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org labels Sep 26, 2023

plummercj reviewed Sep 26, 2023

View reviewed changes

test/hotspot/jtreg/ProblemList.txt Outdated Show resolved Hide resolved

plummercj reviewed Sep 26, 2023

View reviewed changes

test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/ji06t001.cpp Outdated Show resolved Hide resolved

plummercj reviewed Sep 26, 2023

View reviewed changes

test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetJNIFunctionTable/setjniftab001/setjniftab001.cpp Outdated Show resolved Hide resolved

dholmes-ora suggested changes Sep 26, 2023

View reviewed changes

OSU-Machine-One added 3 commits September 27, 2023 06:18

Revert "AttachCurrentThread() failure solution"

f8853ba

This reverts commit b2648f0.

AttachCurrentThread() failure solution

210eadf

Added pthread attritubes to libterminatedThread.c

51ffd3c

Added pthread attritubes to libterminatedThread.c

1b4290e

dholmes-ora suggested changes Sep 28, 2023

View reviewed changes

test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.cpp Outdated Show resolved Hide resolved

test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.cpp Show resolved Hide resolved

JDK-8219652: [aix] Tests failing with JNI attach problems.

4c88e5e

dholmes-ora approved these changes Sep 28, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2023

Update the full name

44e2c8f

Copyrights updated

848d4d8

plummercj approved these changes Sep 28, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2023

sspitsyn approved these changes Sep 29, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Oct 4, 2023

openjdk bot closed this Oct 4, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8219652: [aix] Tests failing with JNI attach problems. #15924

JDK-8219652: [aix] Tests failing with JNI attach problems. #15924

varada1110 commented Sep 26, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 26, 2023

openjdk bot commented Sep 26, 2023

mlbridge bot commented Sep 26, 2023 •

edited

Loading

plummercj commented Sep 26, 2023

dholmes-ora left a comment

varada1110 commented Sep 27, 2023

dholmes-ora left a comment

dholmes-ora left a comment

openjdk bot commented Sep 28, 2023

openjdk bot commented Sep 28, 2023 •

edited

Loading

plummercj commented Sep 28, 2023

varada1110 commented Sep 28, 2023

plummercj commented Sep 28, 2023

plummercj commented Sep 28, 2023

varada1110 commented Sep 29, 2023

varada1110 commented Sep 29, 2023

openjdk bot commented Sep 29, 2023

sspitsyn left a comment

offamitkumar commented Oct 4, 2023

openjdk bot commented Oct 4, 2023

openjdk bot commented Oct 4, 2023

JDK-8219652: [aix] Tests failing with JNI attach problems. #15924

JDK-8219652: [aix] Tests failing with JNI attach problems. #15924

Conversation

varada1110 commented Sep 26, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Sep 26, 2023

openjdk bot commented Sep 26, 2023

mlbridge bot commented Sep 26, 2023 • edited Loading

Webrevs

plummercj commented Sep 26, 2023

dholmes-ora left a comment

Choose a reason for hiding this comment

varada1110 commented Sep 27, 2023

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 28, 2023

openjdk bot commented Sep 28, 2023 • edited Loading

plummercj commented Sep 28, 2023

varada1110 commented Sep 28, 2023

plummercj commented Sep 28, 2023

plummercj commented Sep 28, 2023

varada1110 commented Sep 29, 2023

varada1110 commented Sep 29, 2023

openjdk bot commented Sep 29, 2023

sspitsyn left a comment

Choose a reason for hiding this comment

offamitkumar commented Oct 4, 2023

openjdk bot commented Oct 4, 2023

openjdk bot commented Oct 4, 2023

varada1110 commented Sep 26, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 26, 2023 •

edited

Loading

openjdk bot commented Sep 28, 2023 •

edited

Loading